Re: [WebERP-developers] correction for the ConvertNumberToWordsfunction

[<st...@se...>]

Last discussion about this I remember on the list was you, Phil, speaking
about looking at the PEAR function and it sounded like you might have been
thinking about working on it.  No one came in to say they were working on
it instead if I recall correctly.  So i'm not sure how you would be taking
over anything from anyone.

I was done for the interim after I submitted it.  As I mentioned I don't
consider typing the words manually a big issue.  At the same time
automated words would be better as long as they are reliable!

Steve


-----Original Message-----
From: Phil Daintree [mailto:we...@pa...]
Sent: Sunday, October 22, 2006 5:35 PM
To: john cole; webERP Developers
Subject: Re: [WebERP-developers] correction for the
ConvertNumberToWordsfunction


Hi John,

Great to have CPA contribute to our system!

The ConvertNumbersToWords function has been the bone of some contention
actually. Due to the issues with the function and the fact that it can't
cope with multi-language numbers, I'm keen to see a solid multi-language
function - and there is one already as a PEAR module, which does need
very minor modification to work without other PEAR modules. I have been
criticised previously for "taking over" someone else's development which
kind of demotivates the person that kicked it off. Surely, I can be
forgiven for stepping into this one now :-) There are several loose ends
which need to be sorted before a 3.05 release:

1. Gareth's code for vtiger
2. Cheque writing as above

In these days of Internet banking and bank software that allows send
electronic entry of tranfers directly - it would be great to have the
system create a file that could be imported into the bank software to
initiate transfers.

Its certainly good to get this fixed and remind us about this loose end!

Regards

Phil

john cole wrote:
> Gentlemen,
>
> I have made the correction to the ConvertNumberToWords function in
> includes/MiscFunctions.php to cause the conversions to be correct for
> the numbers between 1000 and 5000.  I have included both a new version
> of the MiscFunctions.php file and a diffs.txt file with the single
> change.  I hope this is helpful to you.  You guys have done a
> tremendous job in writing this software, I have only been working with
> it for a couple of weeks to do some customization for my companies'
> internal use, but I am very impressed with your project.
>
> Sincerely,
>
> John G. Cole, CPA
> LGL
> Bryan, Texas
> ------------------------------------------------------------------------
>
> --- ../webERP/includes/MiscFunctions.php	2006-08-07 04:32:27.000000000
-0500
> +++ includes/MiscFunctions.php	2006-10-22 09:22:56.000000000 -0500
> @@ -152,11 +152,10 @@
>         // Special case written as fifty-nine hundred.
>         // e.g. thousands digit is 1..5 and hundreds digit is 1..9
>         // Only when no further higher order.
> -
>         // doing hundreds
>  			 if ( $i == 1 && 1 <= $num && $num <= 5 ){
>             if ( $remdr > 0 ){
> -               $remdr += $num * 10;
> +	   $remdr = $num * 10;
>                 $num = 0;
>             } // end if
>         } // end if
>
> ------------------------------------------------------------------------
>
> Internal Virus Database is out-of-date.
> Checked by AVG Free Edition.
> Version: 7.1.394 / Virus Database: 268.12.8/455 - Release Date: 22/09/2006
>


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Web-erp-developers mailing list
Web...@li...
https://lists.sourceforge.net/lists/listinfo/web-erp-developers