Re: [Vxl-users] [Vxl-maintainers] VC9 aka VS2008

[Johnson, H. J <han...@ui...>]

Thank you Brad.

https://github.com/vxl/vxl/pull/202


I have a hope that vnl_math::abs(long double)  can just be std::abs(long double).

In fact I am hoping that we can remove as many special cases as possible so that vnl_math:: is really just an alias for std::.

The only place where there is still conditional logic for the simpler case is with VC9 support.

Thank you for reporting the failures that are going to occur with the proposed pull request.

Hans

-- 









On 2/26/16, 9:26 AM, "Brad King" <bra...@ki...> wrote:

>On 02/25/2016 10:01 PM, Johnson, Hans J wrote:
>> _MSC_VER = 1500,  Visual Studio 2008 = Version 9.x
>> 
>> There is a few remnants of code that claim it is needed for Version8
>> and Version7, but are in the Version9 files.  If I can confirm that
>> Version9  does not need these work arounds, we can significantly
>> simplify some code to make it easier to maintain and easier to
>> review in the future.
>> 
>> Please let me know if you could build the current version of VXL under VS9?
>
>I have it.  Is there a PR to be tested?
>
>-Brad