Re: [Vxl-maintainers] [Vxl-users] [PATCH] fixes for some clang static analyzer warnings

[Joseph M. <mu...@le...>]

Amitha,
For some reason I didn't receive the root email that must have triggered
your queries. Could you forward that to me?
Thanks,
Joe

-----Original Message-----
From: Amitha Perera [mailto:ami...@us...] 
Sent: Thursday, September 13, 2012 6:08 PM
To: 'Vxl-maintainers'; Sean McBride
Subject: Re: [Vxl-maintainers] [Vxl-users] [PATCH] fixes for some clang
static analyzer warnings

On 9/13/2012 5:32 PM, Sean McBride wrote:
> hmmm, I'm not sure it makes sense to simply commit the patch as is... 
> aren't said developers on this list? Cheers, 

I agree.

Joe, some of the comments are in brl.  Could someone at Brown have a look?

Ian, some of the comments are in mul.  Could you forward it to someone?

Joe, one of the comments applies to vpgl. You are the last name in the 
history, because you moved the file to core.  Do you know who 
contributed the code?

Sean, the comment on vbl

TEST("something????", success, true); //"success" was ignored, I'm 
guessing it's meant to be checked.

seems incorrect. That macro should expand out to something like

if( success == true ) cout << "Something?"

I.e., the value is used.

Amitha.


----------------------------------------------------------------------------
--
Got visibility?
Most devs has no idea what their production app looks like.
Find out how fast your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219671;13503038;y?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
_______________________________________________
Vxl-maintainers mailing list
Vxl...@li...
https://lists.sourceforge.net/lists/listinfo/vxl-maintainers