From: Joseph M. <mu...@le...> - 2010-01-13 14:52:54
|
Peter, That is fine, go with BUILD_NONCOMMERCIAL I was just put off a bit by the double negative. Joe -----Original Message----- From: pe...@va... [mailto:pe...@va...] Sent: Wednesday, January 13, 2010 8:31 AM To: Joseph Mundy Cc: 'Vxl-maintainers' Subject: Re: Restricted polygon code Joe Mundy wrote: > Ok, so let's go with > BUILD_COMMERCIAL The goal of this new setting is to avoid that people who want to build a commercial application using vxl, won't by accident use GPL (or similar) source code. So by default, this setting must be ON. The C++ source will thus need a #ifndef BUILD_COMMERCIAL ... #endif around GPL code. So I see a disadvantage with this solution: people who build the code *without* any setting (e.g. because they don't use CMake, or and old version of the generated makefiles, or whatever) will accidentally *include* the GPL code! Therefore, if indeed BUILD_COMMERCIAL should be the default --which is to be overridden only *on purpose*-- shouldn't we preferably use something like BUILD_NONCOMMERCIAL as a CMake setting, which is then of course *not* set by default? In that case, the conditioning around GPL code would instead become: #ifdef BUILD_NONCOMMERCIAL ... #endif -- Peter. |