Re: [Vxl-users] bug report & bug fix in coplanar method

[Peter V. <pet...@ya...>]

Guillaume, Amitha,

I believe I've already fixed this (on 2009-02-14).
And added test cases for it in core/vgl/tests/test_homg.cxx.
This was after release vxl 1.12, so you'll have to verify whether it works through a CVS download of core/vgl/vgl_homg_point_3d.h.
Anyhow, I applied the fix exactly as suggested.

--      Peter.


--- On 2009-03-06, Amitha Perera wrote:
> Från: Amitha Perera <ami...@us...>
> Ämne: Re: [Vxl-users] bug report & bug fix in coplanar method
> Till: gui...@su...
> Kopia: vxl...@li...
> Datum: fredag 6 mars 2009 15.36
> 
> Guillaume,
> 
> Sorry for the extremely delayed response.
> 
> Could you please create a test case that illustrates the
> bug, and which can then be used in regression testing?
> 
> Thanks,
> Amitha.
> 
> 
> gui...@su... wrote:
> > Hi, the aforementioned method is :
> > 
> > bool coplanar (vgl_homg_point_3d<Type> const &p1,
> >                vgl_homg_point_3d<Type> const &p2,
> >                vgl_homg_point_3d<Type> const &p3,
> >                vgl_homg_point_3d<Type> const &p4)
> > Its computes the determinant Det of matrix :
> > |x1 x2 x3 x4|
> > |y1 y2 y3 y4|
> > |z1 z2 z3 z4|
> > |w1 w2 w3 w4|
> > Then returns (Det == 0)
> > However, it uses a wrong formula to compute Det.
> > Sign should be -1 for w1 coeff, +1 for w2 coeff, -1 for w3, +1 for w4.
> > You could fix this bug with the following code :
> > .....
> > 
> > Guillaume Mersch
> > 







      ___________________________________________________
Sök efter kärleken!
Hitta din tvillingsjäl på Yahoo! Dejting: http://ad.doubleclick.net/clk;185753627;24584539;x?http://se.meetic.yahoo.net/index.php?mtcmk=148783