Re: [Vxl-maintainers] Remove FindwxWidgets from vxl Repository

[Miguel A. Figueroa-V. <mi...@ie...>]

Hello Matt,

On Thu, Jul 3, 2008 at 11:39 AM, Matt Leotta wrote:
> Miguel,
>
>  I agree, there are certainly some old CMake modules that don't need
> to be there anymore.  For any module that is in CMake 2.4.5 I propose
> that we redirect VXL to use the CMake version.  If this doesn't break
> the dashboard then the VXL copies of the modules can go.  If it does
> break the dashboard we either need to update the VXL CMakeLists.txt
> somehow, or submit a patch to CMake to fix the module.

Sounds good to me. I can help with this... Of course, I know we are
all busy and this is sort of secondary, but there aren't many modules
so taking it one at a time we might get there soon ;)

>  I admit that I'm guilty of adding a module or two without submitting
> them to CMake.  How do I submit them to CMake?  Do I have to become a
> CMake developer and check it in to their CVS or SVN?  I looked once
> for a simple way to submit them but didn't find much.  If someone can
> fill me in I'll take care of the modules that I've added.

You should open a feature request in the mantis bug tracker
(http://public.kitware.com/Bug). If you want to further become a
maintainer, then you can post to the list and they will give you write
access to the Modules directory. Look at:

 http://www.cmake.org/Wiki/CMake:Module_Maintainers

If they are simple modules like the FindCoin3D.cmake and
FindSIMVoleon.cmake I can volunteer to maintain them. Actually, I have
a few changes I want to discuss with you for these two modules. I'll
send those in another e-mail after I test them.

--Miguel

> Thanks,
> Matt
>
> On Thu, Jul 3, 2008 at 11:03 AM, Miguel A. Figueroa-Villanueva wrote:
>> Hello,
>>
>> It's been a while since I've contributed anything here... Hope
>> everyone is doing well.
>>
>> Now that the CMake minimum required version has been bumped up to
>> 2.4.5 (as specified in the root CMakeLists.txt), I would like to
>> propose the removal of the
>> config/cmake/Modules/NewCMake/FindwxWidgets.cmake, which I committed
>> about 2 years ago.
>>
>> CMake 2.4.5 and up already contain this module, which I'm the author
>> and maintainer. So, if nobody objects I'll make the necessary changes
>> in vxl to remove the module.
>>
>> Actually, some of the other modules might be ready for removal...
>> FindX11, FindOpenGL, FindDCMTK, seem to be pretty similar to what is
>> currently in CMake. And others should be posted for addition to CMake,
>> so that they can be removed in the future.
>>
>> --Miguel
>>
>> --
>> Miguel A. Figueroa Villanueva
>> +1 787 832-4040 x.3205
>> Department of Electrical and Computer Engineering
>> University of Puerto Rico - Mayagüez Campus