Menu
▾
▴
Re: [VuFind-Tech] Koha users, please review: KohaRest ILS driver
|
From: Ere M. <ere...@he...> - 2016-10-21 14:41:30
|
I'm not sure how things work in Koha, but is it possible that you should be able to place holds on different items in case they are e.g. different issues of a magazine or something? In that case I think it should be left to the ILS to decide if placing a hold is allowed. --Ere 21.10.2016, 16.19, Theodoros Theodoropoulos kirjoitti: > Indeed Tom, I verified your findings with the latest Koha master. So I > suppose they fixed the ILSDI bug in the meantime! > > I was testing against Koha 3.20.10 and the bug is still there. I have > screenshots where one may see multiple holds from the same user to the > same item coming from the ilsdi.pl API using a URL request. At least > this reassures that it was not something wrong with your VuFind's driver ;) > > So in the end, I suppose adding an extra check in the VuFind ILSDI > driver would: > - instead of showing the user that the hold was placed successfully, > VuFind would return an error, saying ie "It seems you have already > reserved this item." (applicable to all Koha versions) and also > - prevent duplicate lines to be added to the database (applicable to > users running certain Koha versions) > > It's just a few lines of code, adding an extra sql query only after a > user requests a hold on a specific item, so it will not pose a > performance issue. > > Theodoros > > PS. > Just out of curiosity, which version of Koha are you testing on? > For the tests that you made (that did not return an error in VuFind > part) what returnCode did you get? For the latest Koha, the returncode > should be "NotHoldable", but in that case placeHold in VuFind's driver > should return 'false' along with the return code and not act as if the > hold was placed... > > On 20/10/2016 4:15 μμ, Tom Misilo wrote: >> >> Theodoros, >> >> >> >> I just tried to reproduce it on my site, but I cannot. In VuFind I am >> utilizing holds_mode = “all”. >> >> >> >> I am able to place “multiple holds” that show up as being placed, but >> when I look at VuFind’s Holds and Recalls, I only show a single hold, >> and again in Koha’s staff side and public OPAC side, I only see a >> single hold under my account. So if you could create the PR, I would >> be happy to look at it, and see if it changes my interaction with >> VuFind at all. And if it is allowing more than one Hold, it may be an >> issue with the ILSDI driver in Koha, as that is where the information >> is being passed it. >> >> >> >> Tom >> >> >> >> *From:*Demian Katz [mailto:dem...@vi...] >> *Sent:* Thursday, October 20, 2016 8:57 AM >> *To:* Theodoros Theodoropoulos <th...@ph...>; >> vuf...@li... >> *Subject:* Re: [VuFind-Tech] Koha users, please review: KohaRest ILS >> driver >> >> >> >> I can’t think of a reason why anyone should be allowed to create more >> than one hold on the same item, so I’d be inclined to suspect a bug on >> the Koha end. I don’t object to a PR to block this from the VuFind >> side to work around the bug; it never hurts to have a bit of extra >> validation. >> >> >> >> - Demian >> >> >> >> *From:*Theodoros Theodoropoulos [mailto:th...@ph...] >> *Sent:* Thursday, October 20, 2016 6:49 AM >> *To:* Demian Katz; vuf...@li... >> <mailto:vuf...@li...> >> *Subject:* Re: [VuFind-Tech] Koha users, please review: KohaRest ILS >> driver >> >> >> >> Hello everyone, >> >> We have been experimenting lately with KohaILSDI driver and we came >> across an issue with holds (which is one of the long-awaited features >> the 'classic' driver didn't provide). >> >> Right now, as I understand, a user is able to place several holds to >> the SAME item. >> I don't know what is the case with other ILS drivers, but this >> behavior is not allowed when using the standard Koha interface (so I >> wonder how it is allowed from Koha's ILS-DI -possibly a bug?). >> >> In any case, if you believe that this should be fixed (at least at the >> VuFind side) so that users who try to place more than one hold on the >> exact same item would get a warning instead of placing a hold, a >> colleague has done some preliminary tests in the KohaILSDI driver and >> I could create a PR with the relevant code. >> >> Cheers, >> Theodoros >> >> On 13/4/2016 3:39 μμ, Demian Katz wrote: >> >> Hello, >> >> >> >> Just a heads-up to any Koha users out there that more work has >> been done on a new ILS driver to take advantage of the recently >> introduced Koha API. See this pull request for details: >> >> >> >> https://github.com/vufind-org/vufind/pull/486 >> >> >> >> I expect that we’ll have to wait until VuFind 3.1 to merge this >> into master given the current code freeze, but since this is >> simply adding a new driver class without modifying any existing >> code, I could be persuaded to include it in 3.0 if there is >> overwhelming positive feedback. (I expect that it’s much more >> likely that a bit more discussion will be necessary). In any case, >> any time Koha users can spend testing this out would be greatly >> appreciated! >> >> >> >> - Demian >> >> >> >> ------------------------------------------------------------------------------ >> >> Find and fix application performance issues faster with Applications Manager >> >> Applications Manager provides deep performance insights into multiple tiers of >> >> your business applications. It resolves application problems quickly and >> >> reduces your MTTR. Get your free trial! >> >> https://ad.doubleclick.net/ddm/clk/302982198;130105516;z >> >> >> >> _______________________________________________ >> >> Vufind-tech mailing list >> >> Vuf...@li... >> <mailto:Vuf...@li...> >> >> https://lists.sourceforge.net/lists/listinfo/vufind-tech >> >> >> > > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, SlashDot.org! http://sdm.link/slashdot > > > > _______________________________________________ > Vufind-tech mailing list > Vuf...@li... > https://lists.sourceforge.net/lists/listinfo/vufind-tech > -- Ere Maijala Kansalliskirjasto / The National Library of Finland |