Menu
▾
▴
[Vufind-admins] [VuFind Issues] (VUFIND-1124) Change major in users table to allow null values
|
From: Demian K. (JIRA) <dem...@vi...> - 2016-07-27 12:26:02
|
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> <meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://vufind.org/jira" /> <title>Message Title</title> </head> <body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429"> <table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt"> <!-- header here --> <tr> <td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px"> <table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt"> <tr> <td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="cid:jira-generated-image-avatar-demiankatz-2d4a7fe3-fc2b-4cfe-9546-fe3f91d69bca" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" /> </td> <td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="demiankatz" id="email_demiankatz" href="https://vufind.org/jira/secure/ViewProfile.jspa?name=demiankatz" style="color:#3b73af;; color: #3b73af; text-decoration: none">Demian Katz</a> <strong>resolved</strong> as <strong>Fixed</strong> </td> </tr> </table> </td> </tr> <tr> <td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px"> <table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate"> <tr> <!-- there needs to be content in the cell for it to render in some clients --> <td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly"> </td> </tr> <tr> <td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; border-bottom: none; padding-bottom: 0"> <table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px"> <tr> <td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0"> Thanks for testing that! I've merged your pull request and will close this ticket -- for now, we can leave the DB structure as is. <br /> <br /> I am still a bit confused as to why you're seeing this with CAS but I'm not seeing it with Shibboleth. I do gather that some newer Linux distributions have been shipping MySQL with stricter default settings. Perhaps that is the explanation -- I'm using an older version which auto-converts nulls, while you're using a newer version with stricter standards enforcement. If that's the case, we may want to make a matching change to the Shibboleth auth. </td> </tr> </table> </td> </tr> <tr> <td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff"> <table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt"> <tr> <td class="page-title-pattern-first-line " style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://vufind.org/jira/browse/VUFIND" style="color: #3b73af; text-decoration: none">VuFind</a> / <a href="https://vufind.org/jira/browse/VUFIND-1124" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-static-improvement-08579a99-bee4-4b9d-8775-1177b06dd127" height="16" width="16" border="0" align="absmiddle" alt="Improvement" style="vertical-align: text-bottom" /></a> <a href="https://vufind.org/jira/browse/VUFIND-1124" style="color: #3b73af; text-decoration: none">VUFIND-1124</a> </td> </tr> <tr> <td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://vufind.org/jira/browse/VUFIND-1124" style="color: #3b73af; text-decoration: none">Change major in users table to allow null values</a> </span> </td> </tr> </table> </td> </tr> <tr> <td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff"> <table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt"> <tr> <th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0"> Change By: </th> <td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="demiankatz" id="email_demiankatz" href="https://vufind.org/jira/secure/ViewProfile.jspa?name=demiankatz" style="color:#3b73af;; color: #3b73af; text-decoration: none">Demian Katz</a> </td> </tr> <tr> <th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0"> Status: </th> <td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">Open</span> <span class="diffaddedchars" style="background-color:#ddfade;">Resolved</span> </td> </tr> <tr> <th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0"> Fix Version/s: </th> <td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <span class="diffaddedchars" style="background-color:#ddfade;">3.0.3</span> </td> </tr> <tr> <th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0"> Resolution: </th> <td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <span class="diffaddedchars" style="background-color:#ddfade;">Fixed</span> </td> </tr> </table> </td> </tr> <tr> <td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff"> <table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <tr> <td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0"> <table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt"> <tr> <td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://vufind.org/jira/browse/VUFIND-1124#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-85aaf50e-4981-4661-81ac-b7db2113e38f" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle" /> </a> </td> <td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://vufind.org/jira/browse/VUFIND-1124#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td> </tr> </table> </td> </tr> </table> </td> </tr> <!-- there needs to be content in the cell for it to render in some clients --> <tr> <td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly"> </td> </tr> </table> </td> </tr> <tr> <td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px"> <table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt"> <tr> <td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v6.2.6#6264-<span title="ee7642271310c09537d01e5848a003c4498a0eed" data-commit-id="ee7642271310c09537d01e5848a003c4498a0eed}">sha1:ee76422</span>)</span> </td> <td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top"> <table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt"> <tr> <td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-2d7d65a4-151d-45ad-8294-0504af0aa76c" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix" /> </td> </tr> </table> </td> </tr> </table> </td> </tr> </table> </body> </html> |