Re: [VuFind-Tech] ILS driver method signature change proposal

[Ere M. <ere...@he...>]

My only objection is that the PR also removes patron from a set of 
protected methods, which shouldn't be done since even though the 
parameter may be unused in the base class, there might be derivatives 
using it.

--Ere

3.4.2014 16.10, Demian Katz kirjoitti:
> I just received this pull request:
>
> https://github.com/vufind-org/vufind/pull/129
>
> This changes the signature of the ILS driver’s getHolding method from
> ($id, $patron = false) to ($id, array $patron = null).
>
> I think this is an improvement, but since it changes a long-established
> interface (even though in a minor and subtle way), it gives me some
> pause. Does anyone object to making this change as of VuFind 2.3?
>
> - Demian
>
>
>
> ------------------------------------------------------------------------------
>
>
>
> _______________________________________________
> Vufind-tech mailing list
> Vuf...@li...
> https://lists.sourceforge.net/lists/listinfo/vufind-tech
>


-- 
Ere Maijala
Kansalliskirjasto / The National Library of Finland