From: Lutz B. <lbi...@nl...> - 2012-05-11 15:54:22
|
Hi, Makes sense, the new patch checks if the mobile theme is set. Regarding 2.) one thing we are going to do is implement a "notAvailableMobile.tpl" which gets displayed on pages that aren't implemented in the mobile view when the user is using the mobile theme. It redirects the user to the standard view if they want to access that particular feature or they can go to the mobile homepage or use the back button to stay in the mobile theme. It's not ideal from an implementation point, since we need to add a .tpl file for each "unimplemented" page, otherwise we get a smarty error(of course these errors exist now also when accessing those pages directly with an url for example). The place we noticed this is the collections module, since we will have links to collection pages, and those links may be opened from mobile devices. However we don't plan on implementing the functionality in the mobile view as it's probably too complex. So under the mobile theme templates we have "Collection/view.tpl" and "Collection/view-alt.tpl" which just include the "notAvailableMobile.tpl" file. Another problem with this behavior may be that we play "theme ping pong" with the user: "try our mobile view!"... "This page needs standard view."... etc. Still for us at least it's probably better to keep the user on the current page rather then going to the homepage when switching to the mobile theme, so they don't have to do a complicated search(which might not be possible anyways) in the mobile view just to find the record they were looking at previously. I left that part unchanged as of yet, but if you have a clear preference for the trunk, let me know and I can have a go at implementing it. Cheers, Lutz -----Original Message----- From: Demian Katz [mailto:dem...@vi...] Sent: 10 May 2012 14:44 To: Lutz Biedinger Cc: vuf...@li... Subject: RE: mobile device detection Thanks, Lutz! A couple of comments: 1.) You should check if the mobile_theme is turned on in config.ini; we don't want to display a "switch to mobile view" link on a site that has mobile view disabled. 2.) I'm not sure if it's worth all the effort of recreating the current URL for the link -- since the mobile themes generally have less functionality than the non-mobile themes, there's a chance that the URL won't actually work in mobile mode. Perhaps it would be safer to simply point to the mobile home page. If you feel it's better to keep the current URL, another possibility would be to use a POST form with a blank action in the user interface -- then you don't need to do as much work on the server side (though you would have to add POST processing to the 'ui' parameter handling in web/sys/Interface.php). - Demian > -----Original Message----- > From: Lutz Biedinger [mailto:lbi...@nl...] > Sent: Thursday, May 10, 2012 9:32 AM > To: Demian Katz > Cc: vuf...@li... > Subject: mobile device detection > > Hi, > Please find attached a small patch which enables a link (back) to the mobile > theme on mobile devices when the user is in the standard view. > > The url for the link to the mobile theme gets built in the interface > initGlobals() function so it will be displayed on all pages once a mobile > device is detected. > The "button" is then prominently displayed at the top of layout.tpl, since > otherwise it might not always be apparent to the user on a mobile device if > scrolling were required. > > If anyone has any feedback/suggestions let me know. > > Demian, if there is any specific issues get back to me and I'll take a look at > fixing it and making another patch. Otherwise feel free to commit this to the > trunk if you think it would be useful. > > Cheers, > Lutz > > The contents of this e-mail (including attachments) are private and > confidential and may also be subject to legal privilege. It is intended only > for the use of the addressee. If you are not the addressee, or the person > responsible for delivering it to the addressee, you may not copy or deliver > this e-mail or any attachments to anyone else or make any use of its contents; > you should not read any part of this e-mail or any attachments. Unauthorised > disclosure or communication or other use of the contents of this e-mail or any > part thereof may be prohibited by law and may constitute a criminal offence. > > If you receive this e-mail by mistake please notify the system manager @ > 6030219. > > T? an r?omhphost seo (agus aon iat?n a ghabhann leis) pr?obh?ideach agus r?nda > agus d\'fh?adadh s? a bheith ina chion coiri?il. > > M? bhfuair t? an r?omhphost seo tr? earr?id, dean teagmh?il le bainisteoir an > ch?rais @6030219 The contents of this e-mail (including attachments) are private and confidential and may also be subject to legal privilege. It is intended only for the use of the addressee. If you are not the addressee, or the person responsible for delivering it to the addressee, you may not copy or deliver this e-mail or any attachments to anyone else or make any use of its contents; you should not read any part of this e-mail or any attachments. Unauthorised disclosure or communication or other use of the contents of this e-mail or any part thereof may be prohibited by law and may constitute a criminal offence. If you receive this e-mail by mistake please notify the system manager @ 6030219. Tá an ríomhphost seo (agus aon iatán a ghabhann leis) príobháideach agus rúnda agus d\'fhéadadh sé a bheith ina chion coiriúil. Má bhfuair tú an ríomhphost seo trí earráid, dean teagmháil le bainisteoir an chórais @6030219 |