From: Demian K. <dem...@vi...> - 2011-02-22 14:53:36
|
Copied and pasted from my JIRA comment: A few comments on the patch: 1.) Would it be better to load the library prerequisites in TopPubDateVis.tpl rather than layout.tpl so that they are not always present if the plug-in is disabled? 2.) You should be able to use {js} tags inside the <!--[if IE]> blocks -- you don't have to use hard-coded <script> tags there. 3.) It probably wouldn't hurt to load the data via AJAX instead of embedding it in the templates since the functionality is all dependent on Javascript anyway. 4.) Rather than having a dateVis setting in facets.ini, would it be better to just pass the array through as a delimited list on the recommendation entry in searches.ini? 5.) I think the SearchObject is the right place for the getPublicationDates method -- it should be possible to implement this for Summon as well as Solr, though I have my doubts about WorldCat. Perhaps the recommendation module should be smart enough to fail gracefully if no getPublicationDates method is defined on the SearchObject that it receives. I'll actually try running the code in the near future and may have more comments after that... but these are my initial thoughts after simply looking at the code. Thanks for taking the time to contribute this! - Demian > -----Original Message----- > From: Till Kinstler [mailto:kin...@gm...] > Sent: Monday, February 21, 2011 4:51 PM > To: vuf...@li... > Subject: Re: [VuFind-Tech] Customizing VuFind facets (publishDate and > dateRange) > > I just added a patch for the current trunk to the Jira ticket > http://vufind.org/jira/browse/VUFIND-382 > It adds a recommendations module displaying a plot of publication years > to the top of the search results. For more details see the comment in > Jira. > This is work in progress and I am looking for comments, before > proceeding in the wrong direction, but at least it somewhat works. A > demo (that may work or not from time to time :-)) is at > http://esx-115.gbv.de/vfjq/ > > Till > > Am 16.02.2011 19:17, schrieb Eoghan Ó Carragáin: > > I wonder would it fit as a recommendation module[1] (displayed as a > > "TopRecommendation") which would have the benefit of making it > optional > > or configurable by search-type. The jquery UI slider is already > included > > in the new blueprint/jquery theme. > > > > I added a Wishlist JIRA ticket for this - will I copy your email up > as a > > comment? > > > > Thanks > > Eoghan > > > > [1] http://vufind.org/wiki/building_a_recommendations_module > > > > > > On 16 February 2011 16:45, Till Kinstler <kin...@gm... > > <mailto:kin...@gm...>> wrote: > > > > Am 16.02.2011 15:36, schrieb Eoghan Ó Carragáin: > > > I notice that "Suchkiste" now has a really cool publication > date graph > > > above the search results: > > > > > > http://finden.nationallizenzen.de/Search/Results?lookfor=Joyce&submit=F > inden > > > <http://finden.nationallizenzen.de/Search/Results?lookfor=Joyce&submit= > Finden> > > > > > > <http://finden.nationallizenzen.de/Search/Results?lookfor=Joyce&submit= > Finden > > > <http://finden.nationallizenzen.de/Search/Results?lookfor=Joyce&submit= > Finden>> > > > > > > Till, is this something that could make its way back to the > trunk, or > > > has Suchkiste forked too much? > > > > Uah, that is one of the most ugly parts hacked into Suchkiste. > > It works like this: > > In the SearchObject class we added a method getDateRange that > sends a > > search request to Solr asking for an unlimited number of facet > values > > for the publishDate field sorted lexicographically (which is: by > year). > > That method is called in services/Search/Results.php, so we do an > > additional search there. We need to do that additional search, > because > > we want the date distribution for the user query without filters > applied > > and an unlimited number of facet values sorted by year, not by > facet > > count. The result of that search is passed to the Smarty > frontend, where > > it is displayed using am ugly combination of jQuery flot > > (http://code.google.com/p/flot/) and jQuery Slider > > (http://docs.jquery.com/UI/Slider). We pass the values to flot by > > embedding them in a Javascript variable right in the HTML source > code. > > Not nice, blows up the page and nothing is displayed until the > second > > search is finished... Might be worth doing this in an AJAX call. > > We played with SVG to plot the diagram as well, but browser > support for > > SVG is still too much a mess (or was about half a year ago)... > > We had some issues with flot, for example we first had the graph > in a > > scalable user interface (no fixed page width) and got lots of > display > > errors when resizing the browser window. Now we have a fixed > width > > layout (for other reasons as well), and flot works reasonably. > > I'd be happy to contribute that into mainline VuFind, but I first > should > > have a look at current code in that area to see how it might fit > in. Or, > > if you have ideas, just speak up... > > > > Till > > > > -- > > http://twitter.com/tillk > > > > ----------------------------------------------------------------- > ------------- > > The ultimate all-in-one performance toolkit: Intel(R) Parallel > > Studio XE: > > Pinpoint memory and threading errors before they happen. > > Find and fix more than 250 security defects in the development > cycle. > > Locate bottlenecks in serial and parallel code that limit > performance. > > http://p.sf.net/sfu/intel-dev2devfeb > > _______________________________________________ > > Vufind-tech mailing list > > Vuf...@li... > > <mailto:Vuf...@li...> > > https://lists.sourceforge.net/lists/listinfo/vufind-tech > > > > > > > -- > http://twitter.com/tillk > > ----------------------------------------------------------------------- > ------- > Index, Search & Analyze Logs and other IT data in Real-Time with Splunk > Collect, index and harness all the fast moving IT data generated by > your > applications, servers and devices whether physical, virtual or in the > cloud. > Deliver compliance at lower cost and gain new business insights. > Free Software Download: http://p.sf.net/sfu/splunk-dev2dev > _______________________________________________ > Vufind-tech mailing list > Vuf...@li... > https://lists.sourceforge.net/lists/listinfo/vufind-tech |