Re: [VuFind-Tech] Please test/comment -- Solr POST fix

[Till K. <kin...@gb...>]

Hmmm,

seems I simply quickfixed that some time ago with the patch attached. I 
admit, I don't remember the details (too long ago), but I'm quite sure I 
did not change anything else to get that going. But please test!
Seems addPostData() happily accepts an array as argument...

Till

Demian Katz schrieb:
> I was recently experimenting with using POST instead of GET to 
> communicate with Solr in order to avoid problems caused by GET-related 
> length limitations.  In the process, I noticed a bug -- if I used POST 
> for the main search in Results::processSearch(), limiting by facet 
> broke.  If multiple facets were clicked, only the most recently-added 
> one would be applied as a search limit and earlier limits would be 
> forgotten.
> 
>  
> 
> The problem was caused by the fact that Solr expects multiple "fq" 
> parameters in order to apply multiple limits.  
> HTTP_Request::addPostData() doesn't support multiple POST parameters 
> with the same name, so it just kept overwriting the previous facet name 
> with the most recent one.
> 
>  
> 
> There doesn't seem to be a good high-level way of dealing with this, so 
> I've rewritten the POST code to send the raw parameter string instead of 
> using the addPostData() method.  In addition to fixing the facet 
> problem, it also has the side effect of making the code significantly 
> simpler, since it shares more logic with the GET code.
> 
>  
> 
> This is a pretty significant rewrite, so I'm posting a patch here before 
> committing anything.  If anybody could take a look and let me know if 
> they have concerns about this, I'd appreciate it!
> 
>  
> 
> thanks,
> Demian
> 
> 
> ------------------------------------------------------------------------
> 
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
> trial. Simplify your report design, integration and deployment - and focus on 
> what you do best, core application coding. Discover what's new with 
> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Vufind-tech mailing list
> Vuf...@li...
> https://lists.sourceforge.net/lists/listinfo/vufind-tech


-- 
Till Kinstler
Verbundzentrale des Gemeinsamen Bibliotheksverbundes (VZG)
Platz der Göttinger Sieben 1, D 37073 Göttingen
kin...@gb..., +49 (0) 551 39-13431, http://www.gbv.de