From: Jon G. <jon...@gm...> - 2009-08-21 15:18:05
|
On Fri, Aug 21, 2009 at 10:05 AM, <M....@ls...> wrote: > The debugging didn't show the problem, but we have just noticed a > pattern. The error was happening whenever we clicked on link in the > Search screen that had a publishDate in square brackets. We had only > managed to get publishDate displaying by using the hack suggested in the > attached email. When we turn this off the links work fine - but no > publish date is displayed. > Well, brackets are not allowed in a url. There seems to be lots of places in the VuFind code where things like urlencode or htmlspecialchars should be called on data but are not. Of course, you'll want to make sure you don't double-escape, but without seeing the code I'd suspect you just need to urlescape in an appropriate place, or even better yet do a regular expression to try to clean the url. Of course, I'm not entirely sure what the link is supposed to be taking you too, as that's another issue. If there's some normalization going on, it needs to be stripped as well. Hard to say for certain though, since for some reason I don't see the earlier emails on this thread so I'm not sure what the patch was. Hopefully I'm not just stating what's already known or not too horribly off-track. Jon Gorman |