Menu
▾
▴
Re: [VuFind-Tech] Adding to favourites
|
From: Reuben P. <rd...@au...> - 2009-04-02 17:48:33
|
Hi Andrew,
Thanks for your reply.
I submitted the patches to Jira and Sourceforge:
http://vufind.org/jira/browse/VUFIND-51
also at
http://sourceforge.net/tracker/?func=detail&aid=2727031&group_id=199442&atid=969508
I might be able to help with the repository/patch management
assuming our library commits to use VuFind.
We're supposed to make a decision by the end of summer.
Would you be willing to move the project over to use
Mercurial instead of svn ?
http://www.selenic.com/mercurial/wiki/
A distributed system like Mercurial solves some
problems nicely.
It's easy for a developer or institution to keep
a local repository, then push or pull "change sets"
to/from a master repository when it makes sense.
Easy for subteams to share development code
in a team repository without changing the
master repo till the code is ready.
Easy to setup a workflow where the project
sets up a testing repository whose contents
get pushed into the master (public) repo
after passing regression tests.
Cheers,
Reuben
>>> Andrew Nagy <as...@gm...> 4/2/2009 11:30 AM >>>
Thanks Reuben! Can you please post any patches to the JIRA site so
that
they don't get lost in email?
As to patches and QC - that's a bit of a tricky subject. Traditionally
not
many VuFind sites have posted their customizations back to the
community.
As project leader - I need to be better at helping libraries return
their
enhancements back to the source repository. As to QC - I test all
code
checkins to the SVN repo - but no one is perfect :) I also often tend
to
break the trunk repo when making large changes.
Please feel free to volunteer as code QA guru or patch master if you
are
interested :)
Andrew
On Thu, Apr 2, 2009 at 12:19 PM, Reuben Pasquini <rd...@au...>
wrote:
> Hello VuFind-tech!
>
> Below are a few one-line patches to fix bugs that
> prevent a page from loading.
> I submitted the patched to sourceforge too:
>
>
>
http://sourceforge.net/tracker/?func=detail&aid=2727031&group_id=199442&atid=969508
>
> I work around the add-tag bug described by just
> adding a call to $this->saveRecord();
> in Record/Save.php launch().
>
> I'm surprised to so often come across VuFind code
> that doesn't
> work due to some one-line bug that would have
> been caught if the developer would have just
> tried to load the page.
> Do libraries that run a public VuFind install just
> maintain a local code repo, and not
> submit patches back to sourceforge ?
> Does the VuFind team not require any QC
> before submitting to the master repository ?
>
> Cheers,
> Reuben
>
> $ svn diff -r HEAD Record/AddTag.php MyResearch/Edit.php
> Index: Record/AddTag.php
> ===================================================================
> --- Record/AddTag.php (revision 1194)
> +++ Record/AddTag.php (working copy)
> @@ -52,7 +52,7 @@
> } else {
> $interface->assign('title',
$this->details['title']);
> $interface->setPageTitle('You must be logged in
> first');
> - $interface->assign('subTemplate', 'login.tpl');
> + $interface->assign('subTemplate',
> '../MyResearch/login.tpl');
> $interface->setTemplate('view-alt.tpl');
> $interface->display('layout.tpl', 'AddTag' .
> $_GET['id']);
> }
>
> Index: MyResearch/Edit.php
> ===================================================================
> --- MyResearch/Edit.php (revision 1194)
> +++ MyResearch/Edit.php (working copy)
> @@ -40,7 +40,8 @@
> $resource = Resource::staticGet('record_id',
> $_GET['id']);
> preg_match_all('/"[^"]*"|[^ ]+/', $_POST['tags'],
> $tagArray);
> $user->addResource($resource, $tagArray[0],
> $_POST['notes']);
> - Home::launch();
> + $home = new Home();
> + $home->launch();
> exit();
> }
> Index: Record/Save.php
> ===================================================================
> --- Record/Save.php (revision 1184)
> +++ Record/Save.php (working copy)
> @@ -58,6 +58,8 @@
> exit();
> }
>
> + $this->saveRecord();
> +
> // Get details if they exist
> if ($this->user->hasResource($_GET['id'])) {
> $myTagList = $this->user->getTags($_GET['id']);
>
>
>
>
> >>> Andrew Nagy <as...@gm...> 4/2/2009 10:09 AM >>>
> Greg - as an update. I am reworking the favorites system within
VuFind
> to
> include "lists". This new capability will allow users to add
favorite
> items
> to a list. They will be able to control the visibility of the list
as
> well
> so that it is public or private.
>
> I have much of the code complete and hope to have it checked into
the
> repository soon.
>
> Andrew
>
> On Sun, Mar 29, 2009 at 10:24 PM, Greg Pendlebury
> <pen...@us...>wrote:
>
> >
> > I've somewhat confused myself, because I'm sure I've seen this
> working for
> > our install... but I could be wrong.
> >
> > When you click to add a resource to your favourites from the
search
> results
> > list, the form has no action attribute, just an onsubmit() call to
> the ajax
> > function saveRecord().
> >
> > The problem is that page doesn't have the /Record/ajax.js script
> included.
> >
> > /Record/view.tpl includes the scipt, but (according to
> /Record/Save.php)
> > the save.tpl template is actually displayed under
> /Record/view-alt.tpl,
> > which has no script element.
> >
> > Simple Fix: add the script element to /Record/view-alt.tpl
> >
> > Now I'm getting errors in the .js which makes me think it doesn't
> match the
> > page structure anymore (found a jira issue open for some of the
> errors, but
> > there's others). I'm starting to fix them now, but it begs the
> question 'Am
> > I doing something wrong?'.
> >
> > Is favourites to a feature others use?
> >
> > Ta,
> >
> > *Greg Pendlebury *
> > Electronic Services Officer (Systems Team)
> > Division of Academic Information Services
> > University of Southern Queensland
> > Phone: +61 7 4631 1501
> > Fax: +61 7 4631 1841
> >
> >
> > ------------------------------
> > This email (including any attached files) is confidential and is
for
> the
> > intended recipient(s) only. If you received this email by mistake,
> please,
> > as a courtesy, tell the sender, then delete this email.
> >
> > The views and opinions are the originator's and do not necessarily
> reflect
> > those of the University of Southern Queensland. Although all
> reasonable
> > precautions were taken to ensure that this email contained no
viruses
> at the
> > time it was sent we accept no liability for any losses arising
from
> its
> > receipt.
> >
> > The University of Southern Queensland is a registered provider of
> education
> > with the Australian Government (CRICOS Institution Code No's. QLD
> 00244B /
> > NSW 02225M)
> >
> >
> >
>
>
------------------------------------------------------------------------------
> >
> > _______________________________________________
> > Vufind-tech mailing list
> > Vuf...@li...
> > https://lists.sourceforge.net/lists/listinfo/vufind-tech
> >
> >
>
>
>
------------------------------------------------------------------------------
> _______________________________________________
> Vufind-tech mailing list
> Vuf...@li...
> https://lists.sourceforge.net/lists/listinfo/vufind-tech
>
|