#23 reloading after :empty

open
xaizek
None
5
2012-09-11
2012-04-02
No

When the trash has a lot of files in it, if you open the trash and execute :empty, vifm removes the file in the trash and updates the view of files in the same time it seems. So I can see a block of file disappear, and then another, etc. It seems however that the view is not reloaded at the end, and I need ctrl-l, to see that the trash is really empty.

Just for information, but I guess it's normal (just in case an improvement is possible)
Having a lot of files in the trash, slows down vifm closing.
Having register in vifminfo list and a lot of registers can also slows down vifm start up (around a second I'd say).

Discussion

  • xaizek

    xaizek - 2012-04-06

    reloading after :empty
    The precision of time is limited, so vifm sometimes doesn't catch moment when directory content has been changed. What you see is normal for :empty command since it's run asynchronously in the background. But I'll check place where directory modification time is saved, maybe it's in wrong place (after getting list of files, while it should go before).

    Having a lot of files in the trash, slows down vifm closing.
    Merging of vifminfo file is probably the reason.
    Having register in vifminfo list and a lot of registers can also slows down vifm start up (around a second I'd say).
    Again, it's because of merging.
    Current implementation of vifminfo reading and writing is horrible and I'm going to rewrite it. Thanks to you now I know that their performance should be improved.

     
  • xaizek

    xaizek - 2012-04-22

    Having a lot of files in the trash, slows down vifm closing.
    I have just experienced such an issue having only 13 files in the trash. And when I looked into vifminfo file it contained more than 450000 lines. It was because of missing check for file duplication, which was checked during vifminfo merge, but not on reading vifminfo file on :restart command. It slowed down both starting and quiting vifm. Registers don't seem to have such an issue, but I'll check them additionally for performance issues.

     
  • xaizek

    xaizek - 2012-05-10

    I added a check for availability of time stamps in nanoseconds to configure script and made vifm use those time stamps if they are available, which should fix reloading after :empty.

    I'm not closing this issue yet because of pending vifminfo loading/writing code review.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks