that doesn't seem to work at all. it doesn't show any key presses, except the permanently pressed "0" (still a ? for me).
ah well... i also wonder how the atari CX85 is supposed to wor, the keyboard doesn't work at all if i select this one. also, the KEYPAD_KEYS_NUM 20 doesn^t match the actual number of defined keys. not sure if this is a real issue or if i am doing something wrong.
i get it this isn't the proper place here if it's an issue.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
reopening this - the patch seems buggy. I noticed this while trying to fix the test program
a) please next time also update all comments. after your patch the comments do not match the code anymore (which is super confusing really). I have done that now in r45191 b) the encoding of the values is still wrong, some values are used twice, some never - have a look at the comment in the code. Please tell what is correct :)
edit: OK even your new comments were wrong :) The code is fine apparently.
Last edit: gpz 2024-06-16
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Sorry, attached the wrong diff.
applied in r45187 - thanks!
but now according to "joyride 1.4b" the "0" key seems to be pressed all the time. is that correct?
Is the VICE test program also wrong?
that doesn't seem to work at all. it doesn't show any key presses, except the permanently pressed "0" (still a ? for me).
ah well... i also wonder how the atari CX85 is supposed to wor, the keyboard doesn't work at all if i select this one. also, the
KEYPAD_KEYS_NUM 20doesn^t match the actual number of defined keys. not sure if this is a real issue or if i am doing something wrong.i get it this isn't the proper place here if it's an issue.
And as for the "wrong keys" - are you sure this is not the result of a wrong keymap?
Yes, see my comment on issue #2039.
reopening this - the patch seems buggy. I noticed this while trying to fix the test program
a) please next time also update all comments. after your patch the comments do not match the code anymore (which is super confusing really). I have done that now in r45191
b) the encoding of the values is still wrong, some values are used twice, some never - have a look at the comment in the code. Please tell what is correct :)edit: OK even your new comments were wrong :) The code is fine apparently.
Last edit: gpz 2024-06-16
Also fixed cardkey-c64.prg to work with the current implementation. Please confirm