first, create the patch from the "vice" dir, this patch uses different pathes for new and old file. its also not in unified diff format ...(easiest way is to just use "svn diff")
then, the patch is missing the related changes to cartconv and vice.texi - please add that as well
last not pleast, please attach example rom files for those new sizes, which i can drop into my collection of test files
Last edit: gpz 2021-10-14
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Sorry for this, I had really too much work past few weeks and weekends were spent in hunting stuff for new apartment... I have 4 days of vacation and I'll try to fix both of my patches.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
vice.texi is mostly updated with the cartridge things now, btw - please have a look and apply the respective changes too. cartconv should be fairly easy, just update the table for the cartridge types accordingly.
(yeah similar situation here, which is why i ask to update it rather than doing it myself - still many other things on the todo list until release)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I have made (I hope) all the needed changes. Patch was made with "svn diff" command. I have tested 128 and 256k BIN images and they work as intended. I have also tried 128, 256 and 512k CRT files, but none of them work. I'm not sure if I maybe made a mistake in cartconv configuration for the cartridge. I have also attached sample 128, 256 and 512k BIN and generated CRT files.
this patch has some problems....
first, create the patch from the "vice" dir, this patch uses different pathes for new and old file. its also not in unified diff format ...(easiest way is to just use "svn diff")
then, the patch is missing the related changes to cartconv and vice.texi - please add that as well
last not pleast, please attach example rom files for those new sizes, which i can drop into my collection of test files
Last edit: gpz 2021-10-14
forget that part - I should still add the respective docs to it :=)
however, please also update cartconv
please? :)
Sorry for this, I had really too much work past few weeks and weekends were spent in hunting stuff for new apartment... I have 4 days of vacation and I'll try to fix both of my patches.
vice.texi is mostly updated with the cartridge things now, btw - please have a look and apply the respective changes too. cartconv should be fairly easy, just update the table for the cartridge types accordingly.
(yeah similar situation here, which is why i ask to update it rather than doing it myself - still many other things on the todo list until release)
I have made (I hope) all the needed changes. Patch was made with "svn diff" command. I have tested 128 and 256k BIN images and they work as intended. I have also tried 128, 256 and 512k CRT files, but none of them work. I'm not sure if I maybe made a mistake in cartconv configuration for the cartridge. I have also attached sample 128, 256 and 512k BIN and generated CRT files.
applied in r41123 - thanks!
(you forgot to add 16/32 banks to the check in crt attach :))