#927 Emulators missing Network settings - bug or ?

[MIRKOSOFT]

Hi!

Last few builds I found not in Settings Nextwork - is it bug or what?
Missing in: x128, x64sc, xscpu64, xplus4
Other not checked.

Miro

[compyx]

Looks like configure.proto got broken when it comes to --enable/disable-ethernet and Windows. The behaviour when running configure for win32 is 'inverted': --enable-ethernet disables ethernet support, while leaving it out or specifying --disable-ethernet enables ethernet support.

The Linux port seems to be unaffected.

I think one of the recent PCAP -> RAWNET commits broke this.

[compyx]

Actually, it looks like commit r33445 broke something, this doesn't look right:

-  AC_DEFINE(HAVE_PCAP,,[Support for PCAP library.])
-  AC_DEFINE(HAVE_RAWNET,,[Support for CS8900A ethernet controller.])
-  HAVE_RAWNET_SUPPORT="yes"
+  if test x"$enable_ethernet" != "xyes"; then
+    AC_DEFINE(HAVE_PCAP,,[Support for PCAP library.])
+    AC_DEFINE(HAVE_RAWNET,,[Support for CS8900A ethernet controller.])
+    HAVE_RAWNET_SUPPORT="yes"
+  fi

That should probably be '= "xyes"', not '!= "xyes"'.

Edit: commit r33484 should fix this.

[Querino]

i noticed that too. but honestly, does it even matter? the whole ethernet thingy seems to be buggy, at least in the windows port.

see bug #902

or maybe it's only this example? i don't know.

[compyx]

I don't know either, but at least the menu item is back, so one more bug to 'close'. :)

[compyx]

The ethernet settings turned up in the lastest Pokefinder Win32 build again, so I'm closing this as fixed.