#1796 r42820: Windows / Settings dialog: UI Hierarchical List display height should be independet from right pane content height

[Henning Pingel]

Windows 10 (GTK3VICE-3.7.1-win32 and win64 r42820 from today.)

In the settings dialog, the hierarchical list on the left should consistently use the available vertical space of the popup window to stretch out to a maximum height. Instead, the white area containing the list is not using the available height and when scrolling down in the list with cursor down key, it flickers and changes height. It seems that the reason is that the height of the content of the right pane is applied as height to the left area too.

[compyx]

Yes, the left side with the tree and the check buttons should make use of all vertical space. So for some reason vexpand isn't correctly set on the tree widget (or its scrolled window).

I'll look into it. Thanks for reporting.

[compyx]

I've committed a fix in r42829, please test once our buildbot has created a build here.

[Henning Pingel]

Thank you for your fix, compyx! It works much better now and is much more usable! So the problem I have reported appears to be fixed!

I tested only with GTK3VICE-3.7.1-win64-r42845 from today.

When I browse through the whole tree (using the cursor keys) and expand all nodes then I notice that some of the content on the right is too wide or too high. As a result, the size of the popup window is extended to accomodate all controls. This behaviour seems to be a bit jumpy and surprising, but it is still usable.

"Autofire" and "Drive" pages seem to be the widest pages so the popup controls initial width could be set to a width that acommodates them. "RS232" seems to need the most vertical space. Maybe a scrollcontainer would also make sense for the content to live in?

One or two subpages render very slowly for me: "SID" and "RS232" need one second more to render.

[compyx]

Thanks for testing.

Indeed some of the nodes have content widgets that are too large. I'll be going through all of the nodes soon and adjust the layouts so the settings dialog can have an initial size set that'll fit on, say, a 1280x800 laptop screen.

[compyx]

This issue is fixed, and work has been done to make all settings "pages" use a maximum size (iirc the ROM settings still need work).

Closing as fixed.