#1193 some new compiler warnings of type "warning: 'memmap_mem_store_dummy' defined but not used [-Wunused-function]"

[Querino]

as title says.

is that the correct current behaviour, or did something go wrong here when updating the code?

full list:
~~~
Making all in cart
vsidcpu.c:65:13: warning: 'memmap_mem_store_dummy' defined but not used [-Wunused-function]
static void memmap_mem_store_dummy(unsigned int addr, unsigned int value)
^~~~~~~~~~~~~~~~~~~~~~
c64cpu.c:118:13: warning: 'memmap_mem_store_dummy' defined but not used [-Wunused-function]
static void memmap_mem_store_dummy(unsigned int addr, unsigned int value)
^~~~~~~~~~~~~~~~~~~~~~
c128cpu.c:148:13: warning: 'memmap_mem_store_dummy' defined but not used [-Wunused-function]
static void memmap_mem_store_dummy(unsigned int addr, unsigned int value)
^~~~~~~~~~~~~~~~~~~~~~
petcpu.c:94:13: warning: 'memmap_mem_store_dummy' defined but not used [-Wunused-function]
static void memmap_mem_store_dummy(unsigned int addr, unsigned int value)
^~~~~~~~~~~~~~~~~~~~~~
plus4cpu.c:65:13: warning: 'memmap_mem_store_dummy' defined but not used [-Wunused-function]
static void memmap_mem_store_dummy(unsigned int addr, unsigned int value)
^~~~~~~~~~~~~~~~~~~~~~
cbm2cpu.c:93:13: warning: 'memmap_mem_store_dummy' defined but not used [-Wunused-function]
static void memmap_mem_store_dummy(unsigned int addr, unsigned int value)
^~~~~~~~~~~~~~~~~~~~~~
Making all in arch~~~

[gpz]

yeah i am aware of those... WIP :)

[Querino]

yes, i read about WIP, but i've also seen

marked some more dummy accesses as such, should have been all now

confused me a bit. so... case closed.

[Querino]

btw, for

-xcbm2
-xcbm5x0

there is now a boatload of those errors in the log:

RS232dev: Error - rs232dev_get_status(): Attempted to get status of invalid fd -16385.

is this known too?

[gpz]

never seen this. it surely isnt related to the recent cpu core changes?

[Querino]

weird. i always get this, i did try (windows 7)

• GTK3VICE-3.4-win64-r37525 (pokefinder)
• GTK3VICE-3.4-win32-r37521 (retroplay)
• SDL2VICE-3.4-win32-r37521 (retroplay)
• GTK3VICE-3.4-win64-r37501 (retroplay)

using xcbm5x0.exe -default

all give me almost 400 lines with above error, also my own builds.

and this was NOT the case up to r37483. i cannot test between r37484 and r37500, they do crash.

[gpz]

i can reproduce it on windows, not on linux. this is super strange. you do get it ONLY in cbm2/5x0 and no other emulator?

[Querino]

yes, only in cbm2/5x0

i can see (in the UI) these 2 emus have RS232 baudrates only up to 19'200, while the others either go higher or have no RS232 support at all.
maybe this makes a difference?

[gpz]

no idea why that is the case, but its probably just a UI thing, it shouldnt matter. it doesnt explain why it only happens on windows either - or why it would be connected to the recent changes

[Greg King]

This patch should let you see the message in Unix builds:

Index: src/arch/shared/rs232-unix-dev.c
===================================================================
--- src/arch/shared/rs232-unix-dev.c    (revision 37525)
+++ src/arch/shared/rs232-unix-dev.c    (working copy)
@@ -411,6 +411,10 @@ int rs232dev_set_status(int fd, enum rs232handshak
 /* get the status lines of the RS232 device */
 enum rs232handshake_in rs232dev_get_status(int fd)
 {

+    if (fd < 0 || fd >= RS232_NUM_DEVICES) {
+        log_error(rs232dev_log, "Attempted to get status of invalid fd %d.", fd);
+    }
+
     /*! \todo dummy */
     return RS232_HSI_CTS | RS232_HSI_DSR;
 }

[gpz]

ok, yes. so its cbm2 vs the others. i dont quite understand what happens though :)

[gpz]

ok, so that happens in the acia init/reset (and same happens with eg x64 when using -acia1).

i'd expect this to happen ever since though shrug

[gpz]

after looking around in the code a bit, i am convinced its pure coincidence that the message didnt show up before. try -acia1 with an earlier x64, you'll also get some rs232 related log output, showing completely bogus baud rate for example.

in any case, while being ugly, it seems harmless :)

[Querino]

showing completely bogus baud rate

you mean something like BPS: 20 ?

but does it actually work? sadly i cannot test this.

[Greg King]

You mean something like BPS: 20 ?

But, does it actually work?

It sets the speed of the ACIA emulation; but, it's ignored by devices outside of VICE.

[gpz]

i think the problem here is that acia is initialized but the external device is not. its kind of chicken and egg problem :)

[gpz]

r37529 fixes the useless rs232 errors

[compyx]

Can this be closed?

[gpz]

i will close it when i comitted the last cpu core updates. still needs some more testing :)

[compyx]

Ah okay, I figured it was just the annoying compiler warnings.

[gpz]

r37549 has the missing CPU core updates, which removes the warnings. please test (a lot)