Menu

#1109 probable typos in gtk3 filter chooser pattern globs

v3.3
closed-fixed
compyx
None
GTK3
User Interface
2019-03-18
2019-03-10
No

Hi,

Think there's probably minor typos in glob used to filter files in the gtk3 ui file choosers in v3.3 at least, meaning that e.g. a fliplist.vfl file won't show in the dialog.

https://sourceforge.net/p/vice-emu/code/35871/tree/trunk/vice/src/arch/gtk3/widgets/base/filechooserhelpers.c#l77

  • file_chooser_pattern_fliplist seems to be missing a closing ] in "*.[vV[fF][lL]"
  • nearby file_chooser_pattern_program seems to be missing an opening [ in "*.[pP][rR]gG]"

Thanks!

Discussion

  • compyx

    compyx - 2019-03-11

    Should be fixed now. Thanks for reporting.

    I really wish Gtk would allow some 'case-insensitive' flag in its globbing, would make the patterns look a little more readable :)

     
  • compyx

    compyx - 2019-03-18
    • status: open --> closed-fixed
    • assigned_to: compyx
     

Log in to post a comment.

MongoDB Logo MongoDB