Re: [AGG] source code style

[John H. <jo...@gl...>]

The boost style looks ok, but I can think of some areas where the existing agg style is better, or at least not worse:
1) boost style requires class member variables to end in '_', agg begins them with 'm_'
2) boost style has opening brackets at the end of the line, never on a new line. Agg uses a new line for opening brackets for class/struct bodies, names spaces, and function bodies (except for one-liner functions in header files).

boost style does not address this issue, but I really like the following style: if an if, while, for, or switch header cannot fit in one line and must be wrapped then: 1) curly brackets are required for the statement body, 2) the opening bracket must start on a new line. 

-- john

On Jun 23, 2010, at 3:22 PM, Jim Barry wrote:

> On 2010-06-23 22:39, Stephan Assmus wrote:
>> I have no idea yet what the boost style is, I just hope it doesn't try to encode the type into variable names, which I find greatly reduces readability.
> 
> Gosh no - "Hungarian notation" is a total and utter abomination! Death 
> to Hungarian notation! :-)
> 
> The Boost style guide is here:
> 
> http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml
> 
>> The very simple and strong argument pro a hard 80 char/line limit is that horizontal scrolling sucks. Thus there ought to be "some" limit
> 
> Yes, of course, but 80 characters is a little bit low for modern times, 
> I think. I used to restrict myself to 80 characters but increasingly I 
> found it just wasn't enough so now I don't have a hard limit but I 
> generally code to 100 characters or maybe slightly more. Most of the 
> time I don't get anywhere near that though, as I try to avoid 
> excessively deep nesting and suchlike.
> 
>> In any case, discussions about the perfect style have a great potential to go out of hand
> 
> How true.
> 
>> In general, though I am perfectly happy with the AGG coding style. Changing an entire code base with a decent style to another style could also be considered a waste of time.
> 
> Yes, other than the fixed-pitch whitespace alignment, I don't have a 
> problem with it.
> 
> Cheers,
> 
> - Jim
> 
> 
> ------------------------------------------------------------------------------
> ThinkGeek and WIRED's GeekDad team up for the Ultimate 
> GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the 
> lucky parental unit.  See the prize list and enter to win: 
> http://p.sf.net/sfu/thinkgeek-promo
> _______________________________________________
> Vector-agg-general mailing list
> Vec...@li...
> https://lists.sourceforge.net/lists/listinfo/vector-agg-general