[uml-devel] A patch

[Vincent J. <ja...@en...>]

Do you agree with the following patch (see the enclosed file) ?
- I have written a support to get the Ethernet multicast with UML (I the same 
time, I do not used anyore the Radix tree because I had some 
un-understandable and un-replicable panics when some MAC entries begining 
with 0x333300... was added !)
I tested this code and it supports properly the multicast now.
- I use close instead of shutdown in uml_net_user_close because I always get 
a panic with shutdown.
- I changed ssl.c in order to use /dev/pts/%d instead of /dev/serial/%d that 
was not working with a default mgetty.
- I changed stdio_console.c to use /dev/vc/% instead of /dev/ttys/%d that was 
not working with a default mingetty too ;-(

I could not test it with the current CVS release because the compilation of 
hostfs seems to be broken. But it works with the previous check out (one week 
old):

make[3]: Entre dans le répertoire `/usr/src/uml/linux/arch/um/fs/hostfs'
gcc  -I../../include -D__KERNEL__ -I/usr/src/uml/linux/include -Wall 
-Wstrict-prototypes -O2  -fno-strict-aliasing -g  -U__i386__ -Ui386 
-D__arch_um__ -DSUBARCH="i386" -DNESTING=0   -c -o hostfs_kern.o hostfs_kern.c
In file included from hostfs_kern.c:17:
../../include/user_util.h:149: conflicting types for `read_file'
hostfs.h:49: previous declaration of `read_file'
hostfs_kern.c: In function `hostfs_readpage':
hostfs_kern.c:273: warning: passing arg 1 of `read_file' makes pointer from 
integer without a cast
hostfs_kern.c:273: warning: passing arg 3 of `read_file' makes integer from 
pointer without a cast
hostfs_kern.c:273: too many arguments to function `read_file'
make[3]: *** [hostfs_kern.o] Erreur 1 
(It should be easy to fix it, I get a look when I'll be back next monday).

Tell me what you think ?

  Vincent

PS: This enclosed file, the patch, was made with the current CVS tree.