From: Ingo M. <mi...@el...> - 2007-10-22 23:19:56
|
* Jeremy Fitzhardinge <je...@go...> wrote: > Ingo Molnar wrote: > > we should kill it there too. > > > > the only place where we should _please_ keep those annotations are for > > functions that get called from assembly code. This makes life immensely > > easier for -pg (CONFIG_FUNCTION_TRACING) kernels. > > Should we re-add them for the function pointers in asm-x86/paravirt.h? yes, yes, yes. :-) It was a nightmare to sort it out in -rt (and still is). It's also good documentation - it pinpoints functions that are called from assembly. > Andi argued we should remove them since x86 is unconditionally regparm > now anyway - and they're pretty ugly syntactically. Sure, it doesnt make things prettier, but i didnt see any particular ugliness. Ingo |