[uml-devel] Re: [PATCH 04/12] HPPFS: fix access to ppos and file->f_pos

[Blaisorblade <bla...@ya...>]

On Wednesday 21 September 2005 05:46, Al Viro wrote:
> On Sun, Sep 18, 2005 at 04:09:51PM +0200, Paolo 'Blaisorblade' Giarrusso 
wrote:
> >  static ssize_t read_proc(struct file *file, char *buf, ssize_t count,
> >  			 loff_t *ppos, int is_user)
> >  {
> > @@ -228,17 +237,21 @@ static ssize_t read_proc(struct file *fi
> >  	if (read == NULL)
> >  		return -EINVAL;
> >
> > +	WARN_ON(is_user != (ppos != NULL));

> Eww....  Why not pass the right ppos in all cases?
Ok, can be done too. Was a bit in a hurry.
-- 
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade

	

	
		
___________________________________ 
Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB 
http://mail.yahoo.it