[uml-devel] Re: [PATCH 2.6] 4/7 replace uml_strdup by kstrdup

[Paulo M. <pma...@gr...>]

Pekka Enberg wrote:
> On Tue,  1 Feb 2005 03:28:31 +0000, pma...@gr...
> <pma...@gr...> wrote:
> 
>>diff -buprN -X dontdiff vanilla-2.6.11-rc2-bk9/arch/um/os-Linux/drivers/tuntap_user.c linux-2.6.11-rc2-bk9/arch/um/os-Linux/drivers/tuntap_user.c
>>--- vanilla-2.6.11-rc2-bk9/arch/um/os-Linux/drivers/tuntap_user.c       2004-12-24 21:35:40.000000000 +0000
>>+++ linux-2.6.11-rc2-bk9/arch/um/os-Linux/drivers/tuntap_user.c 2005-01-31 20:39:08.591154025 +0000
> 
> 
> [snip]
> 
> 
>>-               pri->dev_name = uml_strdup(buffer);
>>+               pri->dev_name = kstrdup(buffer);
> 
> 
> Please compile-test before submitting.

I'm really sorry about this...

I've compiled with an allyesconfig to validate the changes, but that 
doesn't build the UML parts :(

Anyway, thanks for pointing this out. I still haven't got feedback 
regarding the acceptance of these patches. If there is a chance they're 
accepted, maybe the best thing to do is to post the series again with 
this correction and the sound patch corrections.

-- 
Paulo Marques - www.grupopie.com

All that is necessary for the triumph of evil is that good men do nothing.
Edmund Burke (1729 - 1797)