Re: [uml-devel] Re: [patch 1/1] SYSEMU: avoid intercepting syscall on return when using SYSCALL again.

[Blaisorblade <bla...@ya...>]

On Friday 29 October 2004 09:51, Gerd Knorr wrote:
> > Here's the patch:
>
> Hmm, your mailer seems to mangle whitespaces, I often can apply your
> patches mailed inline with "patch -l" only (the mime attached ones are
> fine).
>
> Two small fixes I need in the big stack of patches i have now to
> build kernels successfully.  The first is a simple missing include:

> ==============================[ cut here ]==============================
> --- linux-uml-2.6.9.orig/arch/um/os-Linux/signal.c 2004-10-28
> 20:11:02.757586671 +0200 +++
> linux-uml-2.6.9/arch/um/os-Linux/signal.c 2004-10-28 20:23:32.730183963
> +0200 @@ -6,6 +6,7 @@
>  #include <signal.h>
>  #include "time_user.h"
>  #include "mode.h"
> +#include "choose-mode.h"
>  #include "sysdep/signal.h"
I'll make sure that is in.

>  void sig_handler(int sig)
> ==============================[ cut here ]==============================
>
> The second one is a fixup for the host-skas3 patch.  That one is needed
> if you use one source tree for both host and uml builds.  Without that
> fixup the host-skas3 patch breaks uml kernel builds (and also all other
> architectures as only i386 has sysemu right now ...).
Yes, I saw it in your tree. I'm including that in -v7 (I'm holding a bit on 
that to see if any other bug is found).


> It's kida quick&dirty, the real fix probably would be to have the skas
> ptrace stuff in *one* place, guess that isn't going to happen before
> skas is merged mainline through.  Whats the status on skas4 btw.?
See Jeff's diary. He has started again working on that, quite unsuccessfully 
however. If you want to look at the code, you can find it inside the UML 
amd64 patch for 2.6.4 (mm_indirect() is more or less supported for both i386 
and UML).

-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729