Re: [uml-devel] Re: [PATCH]Modules support in 2.6: reaching the complete fix

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 454-5900

On Thu, Dec 18, 2003 at 08:32:50PM +0100, BlaisorBlade wrote:
> I'm going to check... the variables are all set with = so it should work, but 
> my problem is that it seems that the arch/um/Makefile is not included when it 
> descends in sub-directories. 

Hummm, so all the state that's set up by the arch Makefile is made available
in environment variables to the subdir makes?  That's inconvenient.

> However, even if it CAN be put there, I think 
> this should NOT happen, and that it should be cleaned enough to be accepted 
> in mainline. Why?
> I think that it should have to be tuned for each release, and would not be 
> likely to always be tunable(i.e. it could have to be re-engeneered if they 
> change Makefile.lib enough). I don't use in fact an external interface of 
> KBUILD, but I mingle inside its implementation(i.e. I violate encapsulation).

It's UML-specific.  So, if at all possible, it should be in the UML tree,
not in the generic kbuild.

> I don't agree for "instead". I.e. I think that as the first thing this must be 
> fixed, and then we will go hunting the bug for MODVERSIONS(it needs that we 
> post-process userspace files).
> After this, then I could do this user space change(I can't promise for now but 
> I hope I'll be able); 

When the userspace stuff is all nicely hidden under arch/um/os, then whatever
fix you have for the build will apply only to that directory.  Maybe it will
turn out that it can't be hidden in the arch/um/os Makefile, but maybe it
can, and that's the right place to put it, if so.

> but it is a bit problematical because KBUILD isn't 
> built to link objects from different directories.

No one is proposing that.

> Could symlink be accepted as a solution for this(i.e. a symlink from 
> drivers/hostaudio_user.c to some file inside the os/ directory)?

If hostaudio is really Linux-specific, it should just be moved under 
arch/um/os-Linux/drivers along with tuntap and ethertap.

				Jeff