Re: Solution (Re: [uml-devel] Re: Weird hostfs file corruption (mmap?))

[Matt Z. <md...@de...>]

On Mon, Apr 28, 2003 at 09:36:20AM +0200, Henrik Nordstrom wrote:

> Which is for good reasons.. not zeroing the remainder of the page is a 
> security issue.

Indeed.

> memset(buffer, 0, PAGE_CACHE_SIZE) just before the call to read_file 
> in hostfs_readpage should address this problem I think.

It does, thank you.  Now I have only the SIGTERM problem to deal with.  If I
restart the build enough times, it will eventually complete, but this is not
ideal. :-)

> Note: A quick inspection of the hostfs writepage function makes me think
> there is another bug in flushing the last page of modified mmaped files
> with an even page size.

I'm afraid I am not familiar enough with the kernel to quickly grasp that
function.  What is the meaning of page->index?

-- 
 - mdz