RE: [uml-devel] Some cleanups for ubd etc

[McMechan, J. <McM...@na...>]

> From: 	Jeff Dike
> Sent: 	Saturday, April 13, 2002 12:32
> To: 	McMechan, James
> Cc: 	use...@li...
> Subject: 	Re: [uml-devel] Some cleanups for ubd etc 
> 
> McM...@na... said:
> > This is an Apple Macintosh file in AppleSingle format 
> 
> I've been meaning to ask why your patches always come in this odd format.
> There are some garbage bytes at the beginning, then it's a perfectly good
> patch.
That is because I am sending the E-mail from a Mac using Microsoft outlook.
I did not know that it was appearing as a AppleSingle file.  I usually copy
it over to the Mac using scp and then use outlook's insert command. This is
much like the reason I still can't access any CVS system... firewall
problems.
If it ever gives problems tell me and I can try something else but they are
even more complex.

> > I put back the references to INIT_GENDISK (from 2_5compat.h) 
> > I also switched to using the minor()/major() 2.5 style macros 
> 
> Are you trying to maintain one file for both 2.4 and 2.5?  I started
> trying
> that (hence 2_5compat.h) and decided that I was making a mess out of 
> everything, so I started backing the compatibility stuff out.
> 
> 				Jeff
I was just trying to follow the way it appeared you were doing it.  It can
make a mess but getting rid of the static initializer from the main code
path made it a bit neater I thought.  I had not seen that you were
abandoning 2_5compat.h it appeared just a few versions ago.