Menu

Git Code Merge Request #5: Maven POM Update, Patch to UcanaccessCallableStatement for Java >= 7 compilers (merged)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Markus Spann wants to merge 0 commits from /u/markussp/ucanaccess/ to master, 2017-06-07

Please review this pull request containing changes:

pom.xml
Upgraded several dependency versions, expanded developer section, configured scm section for git, added maven-enforcer-plugin to enforce minimum Java and Maven versions

net.ucanaccess.jdbc.UcanaccessCallableStatement
Added two getObject() signatures for Java >= 7 compiler support

Thanks,
Markus

Commit Date  

Discussion

  • Gord Thompson

    Gord Thompson - 2017-06-02

    re: pom.xml - Seeing as we are still targeting Java_6 (for now) would it be preferable to use

    <javaVersion>1.6</javaVersion>
    

     
    instead of

    <javaVersion>1.7</javaVersion>
    

     
    ...? When I updated my project (because Eclipse told me to) it changed my execution environment from "JavaSE-1.6" to "JavaSE-1.7".

     
  • Markus Spann

    Markus Spann - 2017-06-02

    Hi Gord, thanks for spotting this. Your are correct, it should be 1.6 of course. A leftover from a test runs with different Java settings ... another incomplete merge request I guess :)

     
    • Gord Thompson

      Gord Thompson - 2017-06-02

      another incomplete merge request

       
      No problem. You can just add another commit to your maven-pom-update branch and push it to your forked repository. Then open this merge request and hit the "Refresh Commits" button.

       

      Last edit: Gord Thompson 2017-06-05
  • Gord Thompson

    Gord Thompson - 2017-06-05

    @Brian - Are you satisfied with the changes to pom.xml? They look fine to me, but you are more conversant than I am in such things.

     
  • Marco Amadei

    Marco Amadei - 2017-06-05

    Concerned about the compatibility with the java 6 compiler. Did you verify that?

     
    • Gord Thompson

      Gord Thompson - 2017-06-05

      I can confirm that these changes will compile in Eclipse using JDK 1.6.0_45. However, I haven't done a full Maven build from the command line.

       
  • Brian Park

    Brian Park - 2017-06-07

    @Markus: Hey, that's a great trick with the getObject().

    @Marco: This works because under Java7, these getObject() methods satisfy the 2 new interface methods in the Java7 version of CallableStatement. But under Java6, these methods will just compile as normal methods, without overriding anything because they don't have an @Override. I verified that this compiles under (Eclipse, Ubuntu 17.10, Java6) and (Maven, Ubuntu 17.10, Java8).

    pom.xml:

    • 62-64: Just cruious, why do are $hsqldbVersion and $jackcessVersion moved into properties? They are only used once as far as I can tell. And you don't move many other version numbers into properties.

    • 39: I'm in GMT-7 during daylight savings summer, and GMT-8 during normal winter.

    Other than that, this looks good to me. Thanks for making this work for both Java6 and Java >6. That's been quite a bit of a pain in the butt.

    Brian

     
  • Markus Spann

    Markus Spann - 2017-06-07

    Hi Brian, thanks :)
    I defined Maven properties $hsqldbVersion and $jackcessVersion as these are by far the most important dependencies of the project and I thought it'd be good for their versions to stand out and be defined in a common place high up in the POM.

     
  • Gord Thompson

    Gord Thompson - 2017-06-07
    • Status: open --> merged
     

Log in to post a comment.