Thread: [Tuxpaint-devel] Paint tool: Single clicks do nothing
An award-winning drawing program for children of all ages
Brought to you by:
wkendrick
From: Pere P. i C. <pe...@fo...> - 2008-08-14 12:41:03
|
Hi all! Start tuxpaint, in paint tool, do several single clicks withouth dragging the mouse: nothing is drawed. Change to line tool, see how single clicks draws and works fine. Then look closer: do a click withouth drag and whitout release, see how nothing is drawed until you release the mouse. This happens as a side issue of the fix of #1934883 bug. In tuxpaint.c, search for the string "fixes SF #1934883?" (you will find two times, one for draw and one for line tools) I think that the line tool is fine drawing at mouse release as a good compromise between #1934883 and the single click issue of paint tool. This patch adds draw on release to the paint tool: diff tuxpaint.c.back tuxpaint/src/tuxpaint.c 3669c3669,3674 < if (cur_tool == TOOL_LINES) --- > if (cur_tool == TOOL_BRUSH) > { > /* (Drawing on mouse release to fix single click issue) */ > brush_draw(old_x, old_y, old_x, old_y, 1); > } > else if (cur_tool == TOOL_LINES) A sumary of #1934883 bug: Directional brushes gets its first draw always to up, disregarding the direction where they go further. Happened on draw and on line tools. OK to commit? Pere |
From: Bill K. <nb...@so...> - 2008-08-14 15:03:45
|
On Thu, Aug 14, 2008 at 02:41:44PM +0200, Pere Pujal i Carabantes wrote: > Hi all! > > Start tuxpaint, in paint tool, do several single clicks withouth > dragging the mouse: > nothing is drawed. Oh dear. Thanks for catching that. I've applied your patch, and it seems good. It might be even better if we only behaved like this for the directional brushes, but I think it's okay as it is, for now. Another idea would be (when drawing with a directional brush): draw the middle shape on click. If they then drag, undraw it, and draw the appropriate one. Otherwise, if they simply release, they'll get the middle image. Anyway, thx! -bill! |
From: Pere P. i C. <pe...@fo...> - 2008-08-14 16:55:40
|
El dj 14 de 08 de 2008 a les 08:03 -0700, en/na Bill Kendrick va escriure: > On Thu, Aug 14, 2008 at 02:41:44PM +0200, Pere Pujal i Carabantes wrote: > > Hi all! > > > > Start tuxpaint, in paint tool, do several single clicks withouth > > dragging the mouse: > > nothing is drawed. > > Oh dear. Thanks for catching that. I've applied your patch, and it seems > good. It might be even better if we only behaved like this for the > directional brushes, but I think it's okay as it is, for now. This draws on click for non directional brushes only, on both paint and line tools diff tuxpaint.c.back tuxpaint/src/tuxpaint.c 3300,3301c3300,3303 < < /* brush_draw(old_x, old_y, old_x, old_y, 1); fixes SF #1934883? */ --- > if (! brushes_directional[cur_brush]) > { > brush_draw(old_x, old_y, old_x, old_y, 1); /*fixes SF #1934883? */ > } 3332,3334c3334,3337 < < /* brush_draw(old_x, old_y, old_x, old_y, 1); fixes sf #1934883? */ < --- > if(! brushes_directional[cur_brush]) > { > brush_draw(old_x, old_y, old_x, old_y, 1); /*fixes sf #1934883? */ > } Yours Pere |