Re: [Tuxpaint-devel] Per-locale default font
An award-winning drawing program for children of all ages
Brought to you by:
wkendrick
Menu
▾
▴
Re: [Tuxpaint-devel] Per-locale default font
|
From: Shin-ichi T. <dol...@wm...> - 2023-06-18 23:26:56
|
On Sun, 18 Jun 2023 13:38:35 -0700, Bill Kendrick wrote:
>It's doubtful I'll get to it today, as I've got an engagement in a
>bit, but it's nice to get use closer to 'zero warnings' when
>compiling.
>
>At least, that's what it looks like for ME, just doing a plain
>`make` here on my Kubuntu 22.04 system. If anyone else is still
>seeing compiler warnings, please share them so we can try and
>clean up the codebase. It's nice for _real_ errors to not be
>buried in a sea of warnings. :)
Here are warnings on Windows so far.
I will see them when I have time.
src/tuxpaint.c:234:2: warning: #warning "Attempting to define strcasestr(); if errors, build with -DHAVE_STRCASESTR" [-Wcpp]
234 | #warning "Attempting to define strcasestr(); if errors, build with -DHAVE_STRCASESTR"
| ^~~~~~~
src/tuxpaint.c: In function 'mainloop':
src/tuxpaint.c:3747:21: warning: the comparison will always evaluate as 'true' for the address of 'sizes' will never be NULL [-Waddress]
3747 | if (magics[magic_group][cur_thing].sizes)
| ^~~~~~
src/tuxpaint.c:1581:7: note: 'sizes' declared here
1581 | int sizes[MAX_MODES]; /* Whether magic tool accepts sizes */
| ^~~~~
src/tuxpaint.c:4369:23: warning: the comparison will always evaluate as 'true' for the address of 'sizes' will never be NULL [-Waddress]
4369 | if (magics[magic_group][cur_thing].sizes)
| ^~~~~~
src/tuxpaint.c:1581:7: note: 'sizes' declared here
1581 | int sizes[MAX_MODES]; /* Whether magic tool accepts sizes */
| ^~~~~
src/tuxpaint.c:5109:21: warning: the comparison will always evaluate as 'true' for the address of 'sizes' will never be NULL [-Waddress]
5109 | if (magics[grp][cur].sizes)
| ^~~~~~
src/tuxpaint.c:1581:7: note: 'sizes' declared here
1581 | int sizes[MAX_MODES]; /* Whether magic tool accepts sizes */
| ^~~~~
src/tuxpaint.c: In function '_load_svg':
src/tuxpaint.c:21025:5: warning: 'rsvg_handle_close' is deprecated: Use 'rsvg_handle_read_stream_sync' instead [-Wdeprecated-declarations]
21025 | rsvg_handle_close(rsvg_handle, &gerr);
| ^~~~~~~~~~~~~~~~~
In file included from src/tuxpaint.c:517:
C:/msys64/mingw64/include/librsvg-2.0/librsvg/rsvg.h:605:10: note: declared here
605 | gboolean rsvg_handle_close (RsvgHandle *handle, GError **error);
| ^~~~~~~~~~~~~~~~~
src/tuxpaint.c:21039:5: warning: 'rsvg_handle_close' is deprecated: Use 'rsvg_handle_read_stream_sync' instead [-Wdeprecated-declarations]
21039 | rsvg_handle_close(rsvg_handle, &gerr);
| ^~~~~~~~~~~~~~~~~
C:/msys64/mingw64/include/librsvg-2.0/librsvg/rsvg.h:605:10: note: declared here
605 | gboolean rsvg_handle_close (RsvgHandle *handle, GError **error);
| ^~~~~~~~~~~~~~~~~
src/tuxpaint.c:21053:5: warning: 'rsvg_handle_close' is deprecated: Use 'rsvg_handle_read_stream_sync' instead [-Wdeprecated-declarations]
21053 | rsvg_handle_close(rsvg_handle, &gerr);
| ^~~~~~~~~~~~~~~~~
C:/msys64/mingw64/include/librsvg-2.0/librsvg/rsvg.h:605:10: note: declared here
605 | gboolean rsvg_handle_close (RsvgHandle *handle, GError **error);
| ^~~~~~~~~~~~~~~~~
src/tuxpaint.c:21097:5: warning: 'rsvg_handle_close' is deprecated: Use 'rsvg_handle_read_stream_sync' instead [-Wdeprecated-declarations]
21097 | rsvg_handle_close(rsvg_handle, &gerr);
| ^~~~~~~~~~~~~~~~~
C:/msys64/mingw64/include/librsvg-2.0/librsvg/rsvg.h:605:10: note: declared here
605 | gboolean rsvg_handle_close (RsvgHandle *handle, GError **error);
| ^~~~~~~~~~~~~~~~~
src/tuxpaint.c:21113:5: warning: 'rsvg_handle_close' is deprecated: Use 'rsvg_handle_read_stream_sync' instead [-Wdeprecated-declarations]
21113 | rsvg_handle_close(rsvg_handle, &gerr);
| ^~~~~~~~~~~~~~~~~
C:/msys64/mingw64/include/librsvg-2.0/librsvg/rsvg.h:605:10: note: declared here
605 | gboolean rsvg_handle_close (RsvgHandle *handle, GError **error);
| ^~~~~~~~~~~~~~~~~
src/tuxpaint.c:21126:3: warning: 'rsvg_handle_close' is deprecated: Use 'rsvg_handle_read_stream_sync' instead [-Wdeprecated-declarations]
21126 | rsvg_handle_close(rsvg_handle, &gerr);
| ^~~~~~~~~~~~~~~~~
C:/msys64/mingw64/include/librsvg-2.0/librsvg/rsvg.h:605:10: note: declared here
605 | gboolean rsvg_handle_close (RsvgHandle *handle, GError **error);
| ^~~~~~~~~~~~~~~~~
src/tuxpaint.c: In function 'set_label_fonts':
src/tuxpaint.c:26894:15: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
26894 | ttffont = TTF_FontFaceFamilyName(getfonthandle(i)->ttf_font);
| ^
src/tuxpaint.c: In function 'load_embedded_data':
src/tuxpaint.c:27585:15: warning: pointer 'unc_buff' used after 'free' [-Wuse-after-free]
27585 | free(unc_buff);
| ^~~~~~~~~~~~~~
src/tuxpaint.c:27581:15: note: call to 'free' here
27581 | free(unc_buff);
| ^~~~~~~~~~~~~~
src/tuxpaint.c:27646:15: warning: pointer 'unc_buff' used after 'free' [-Wuse-after-free]
27646 | free(unc_buff);
| ^~~~~~~~~~~~~~
src/tuxpaint.c:27642:15: note: call to 'free' here
27642 | free(unc_buff);
| ^~~~~~~~~~~~~~
echo
src/fonts.c: In function 'TuxPaint_Font_OpenFont':
src/fonts.c:342:16: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
342 | familyname = TTF_FontFaceFamilyName(ttf_font); /* N.B.: I don't believe we're supposed to free() this... -bjk 2021.10.26 */
| ^
src/fonts.c: In function 'getfonthandle':
src/fonts.c:1357:20: warning: the comparison will always evaluate as 'true' for the address of 'filename' will never be NULL [-Waddress]
1357 | if (fi->filename != NULL)
| ^~
In file included from src/fonts.c:60:
src/fonts.h:152:9: note: 'filename' declared here
152 | char *filename[4];
| ^~~~~~~~
src/dirwalk.c: In function 'tp_ftw':
src/dirwalk.c:436:2: warning: #warning Failed to see DT_UNKNOWN [-Wcpp]
436 | #warning Failed to see DT_UNKNOWN
| ^~~~~~~
--
Shin-ichi TOYAMA <dol...@wm...>
|
