Re: [Tuxpaint-devel] UI font configuration

[Shin-ichi T. <dol...@wm...>]

Hi!

On Sat, 3 Jun 2023 13:49:34 -0700, Bill Kendrick wrote:
>So please `git pull` the master branch of the "tuxpaint"
>repo and rebuild.  If it still doesn't work, let me know,
>and I'll blame it on another late-night coding session. ;)
>
>Tux Paint Config. does NOT use the same "parse" code, so
>it will now trim quotes IF it finds them at the beginning
>and end of the "uifont=" setting, but ALSO always ADD THEM.

Tux Paint Config adds quotes around the fontname and
Tux Paint seems to consider those quotes as parts of the font
name, then fall back to the default font.

I removed the quotes manually from tuxpaint.cfg file, then
it worked.

I think not adding quotes to the fontname in cfg file may
solve this.

--- a/src/tuxpaint-config2.cxx
+++ b/src/tuxpaint-config2.cxx
@@ -782,7 +782,7 @@ void save_conf(void)
     fprintf(fd, "alllocalefonts=yes\n");

   if ((TEXTINP_uifont_isdef()) == 0)
-    fprintf(fd, "uifont=\"%s\"\n", BROWSER_uifont->text(BROWSER_uifont->value()));
+    fprintf(fd, "uifont=%s\n", BROWSER_uifont->text(BROWSER_uifont->value()));

   /* Printing: */
   /* --------- */


However, it is not consistent with the fact that some other
options needs quotes like printcommand for those who edit cfg
file manually.

Hrm...

-- 
Shin-ichi TOYAMA <dol...@wm...>