Re: [Tuxpaint-devel] Font scoring method

[Shin-ichi T. <dol...@wm...>]

Thank you for your reply.

I understand adding locale characters to the existing criteria works.

However, I am a little at a loss where to put them, because;

 * Japanese has no upper/lower cases distinction.
 * No common/special Japanese panctuations is used in Tux Paint.
 * Numbers are not different to those in ASCII.
 * It has no line-like/circle-like characters.

In addition, I think it would be reasonable to give high priority to the
fonts supporting locale specific characters.

I've pushed the change already, and would like to keep it if this has no
side effect.

Thanks!

On Sat, 17 Dec 2022 14:24:53 -0500, Albert Cahalan wrote:
>> I've looked into the font scoring method in 'dirwalk.c' and 'fonts.c'.
>>
>> The function 'charset_works()' scores up the given font if ALL
>> characters passed to it are correctely rendered.
>>
>> However, it seems to have nothing to do with checking if the font
>> renders given characters distinctly. I was not able to understand what
>> qsort() in charset_works() do.
>>
>>
>> I confirmed that adding Japanese characters to the translations for the
>> strings used for scoring works to place the font supporting Japanese
>> characters on top.
>>
>> The result is good but I am not so confident it is a correct way as
>> originaly intended in font scoring method.
>
>That was the original intent when I wrote the code.
>You should not need to add any code for Japanese.
>Simply adjust the translation to contain a few Japanese
>characters, particularly ones that may be rendered
>indistinctly, and the scoring should work.
>
>
>_______________________________________________
>Tuxpaint-devel mailing list
>Tux...@li...
>https://lists.sourceforge.net/lists/listinfo/tuxpaint-devel


-- 
Shin-ichi TOYAMA <dol...@wm...>