Re: [Tuxpaint-devel] Display bugs in SDL 1.2 (master branch) Tux Paint under X-Window?

[Pere P. i C. <per...@gm...>]

Hi,

El dc. 06 de 07 de 2022 a les 20:36 +0200, en/na Karl Ove Hufthammer va escriure:
> 
> BTW, it would be interesting to know what the root cause of the bug is. 
> Is it a bug in sdl12-compat, SDL2 (since this is what sdl12-compat uses 
> behind the scenes) or Tux Paint? If it’s a bug in sdl12-compat or SDL2, 
> it is likely that other parts of the code could trigger it. It’s such a 
> strange bug, in that only two brushes trigger it, and only if the 
> selected colour is pure black.
> 
> 

Are those brushes?

rgrep rotate data/brushes/
data/brushes/arrow.dat:rotate
data/brushes/rotating_dash.dat:rotate

I remember having to use plain SDL_BlitSurface in the sdl2.0 branch when 
rotational brushes were added, 
was the 6891266eeebd0aa1268dd6ef4c699e3d80e10958 commit
It was for other reasons, no SDL(2)_gfxBlitRGBA() available for the SDL2 lib,
but as you say the sdl2.0 performs right here, the only difference between 
master and sdl2.0 in this area coming to my mind is this one

maybe you could try if it is worth too to use SDL_BlitSurface() insteadSDL_gfxBlitRGBA() 
in the master branch.

HTH
Pere