Re: [Tuxpaint-devel] [Tuxpaint-maintainers] Moving from SDL 1.2 to SDL 2.0

[Shin-ichi T. <dol...@wm...>]

Ah!!

It looks like that my commit for Windows was wrong.

See the commit "4749214383bf7d881e85cb82fea2d751c9b292da"

I thiks following patch will fix it.

--- onscreen_keyboard.c.org	2022-05-20 16:21:47.219690242 +0900
+++ onscreen_keyboard.c	2022-05-20 16:22:49.095034241 +0900
@@ -1865,10 +1865,12 @@
             wcstombs(event.text.text, keyboard->composed, 16);
           //          event.text.text = *keyboard->composed;
           else{
-            //snprintf(event.text.text, 16, "%lc", keysym2unicode(mnemo2keysym(mnemo, keyboard), keyboard));
+#ifdef WIN32
 	    int iwc = keysym2unicode(mnemo2keysym(mnemo, keyboard), keyboard);
 	    wcstombs(event.text.text, (wchar_t *) &iwc, 16);
-          //event.text.text = keysym2unicode(mnemo2keysym(mnemo, keyboard), keyboard);
+#else
+            snprintf(event.text.text, 16, "%lc", keysym2unicode(mnemo2keysym(mnemo, keyboard), keyboard));
+#endif
 	  }
 
           clear_dead_sticks(keyboard);


I think following patch winn
On Thu, 19 May 2022 23:36:39 -0700, Bill Kendrick wrote:
>On Thu, Nov 18, 2021 at 11:57:02PM +0900, TOYAMA Shin-ichi wrote:
>> Hi Bill,
>> 
>> Bill Kendrick wrote in <202...@sh...>
>> >My plan, however, is to release the NEXT version of Tux Paint,
>> >which includes a lot of new features (new Magic tools, and the
>> >Magic tool grouping functionality) using the SDL1.2 branch.
>> >This will be 0.9.27.
>> >
>> >Then, more-or-less immediately, we can try releasing an SDL2.0
>> >version, that adds no new features to Tux Paint itself.
>> >This will be 0.9.28.
>> 
>> Are you still on this track?
>
>BTW, obviously I was not on this track. X^D  Sorry!
>(It's too tempting to add new features, I had some stress
>that made "adding new features to Tux Paint" a stress reliever,
>as weird as that probably sounds.)
>
>
>> I tried to build current sdl2.0 blanch on windows.
>> 
>> It looks almost fine but I found that onscreen-keyboard does not 
>> work correctly with compose function.
>
>Uh oh, hrm, using the sdl2.0 branch here on Kubuntu Linux,
>I am also getting some weird behavior.
>
>When I type [h], [e], [l], [l], [o] with the OSK, I get
>"hello▯" on the canvas, and in the printf()'d output
>from im.c, I noticed:
>
>  im->s o羻, event.text.text o羻
>
>I was _not_ using the compose button.
>
>In fact, playing with it more, as I click the buttons
>to spell "hello" again, I'm getting the "unknown character"
>rectangle a bunch of times.  Just now typing
>"helloooooooo", I see:
>
>  he▯ll▯ooo▯oo▯o▯oo
>
>Oh and interestingly, if I try to type any characters
>that would normally compose, e.g. ~, ', or ", they do not
>appear unless I type them a second time.
>
>So yes, something is definitely broken in the IM stuff
>with the OSK in the sdl2.0 branch!  Sorry I forgot about
>this, but I guess I'm glad I left this email in my mailbox. :-D
>
>Thanks!
>
>-bill!
>
>
>_______________________________________________
>Tuxpaint-devel mailing list
>Tux...@li...
>https://lists.sourceforge.net/lists/listinfo/tuxpaint-devel


-- 
Shin-ichi TOYAMA <dol...@wm...>