Re: [Tuxpaint-users] tuxpaint crash and exit without any error when floodfill complex edges

[雷阳 <lei...@16...>]

Hi


0.9.26 still has crash problem. 
I downloaded the new version and install(override existing one, the installer didn't prompt any dialog asking), 
and by clicking the start menu icon i see the 0.9.26 label on left buttom screen.
I've tested if by default color is black, and the template image is also black, then no issue at all. 
If you select some other color, then fill, it still crashes.


Regards,
Yang

















At 2021-11-16 07:16:57, "Pere Pujal i Carabantes" <per...@gm...> wrote:
>Hi Yang, Welcome,
>Hi Bill,
>
>El dl. 15 de 11 de 2021 a les 15:04 -0800, en/na Bill Kendrick va escriure:
>> On Mon, Nov 15, 2021 at 07:59:14PM +0800, ���� wrote:
>> > Hi,
>> > 
>> > 
>> > This is my first post as a tuxpaint user. This project is great and my 3 years old baby loves it. But sometimes it crashes, do you encounter the same problem and I'm not sure if this is a known issue?
>> > 
>> > 
>> > Steps to reproduce:
>> > 1. New an image, select from built in template, like the following one(i only cropped small part of the image)
>> > 2. Select flood paint tool (i don' know exactly how to call this tool)
>> > 3. Fill to the black edge, instead of the hole.
>> > 
>> > 
>> > Expected result: 
>> > all edges become same color, or no change.
>> >  
>> > Actual result:
>> >  Crash and exit without any error.
>> > 
>> > 
>> > Tuxpaint version: 0.9.25,  Win11 10.0.22000   Build 22000
>> 
>> Hi Yang, thanks for the note, and sorry for the trouble!
>> I made some improvements to the Fill tool in the previous
>> version (0.9.26), when I was working on some new features
>> that the Fill tool offers -- linear & radial gradients.
>> (And 0.9.27 will add a freehand fill option, as well.)
>> 
>> I recall addressing some crash behavior, when dealing
>> with complex shapes, and I just tested with the current
>> 'master' version from the Git source code repository
>> (in other words, what will become version 0.9.27), and
>> was able to easily fill the solid black of the template
>> example you provided.
>> 
>> So I think you should try upgrading to version 0.9.26.
>> If that version still causes difficulty, please let us know
>> and we'll investigate further!
>> 
>> Thanks again,
>> 
>
>I am able to crash Tux Paint with the Fill tool 
>and with the same starter on my android phone, 
>instead in Linux it performs fine when called with the size 
>of the phone.
>
>Instead, if I call Tux Paint with an unreasonable size 
>like 3000x2000, then also in Linux I am able to crash.
>
>Valgrind says the following in Linux:
>==618698== Stack overflow in thread #1: can't grow stack to 0x1ffe801000
>==618698== 
>==618698== Process terminating with default action of signal 11 (SIGSEGV)
>==618698==  Access not within mapped region at address 0x1FFE801FE8
>==618698== Stack overflow in thread #1: can't grow stack to 0x1ffe801000
>==618698==    at 0x16BFB8: would_flood_fill (fill.c:106)
>==618698==  If you believe this happened as a result of a stack
>==618698==  overflow in your program's main thread (unlikely but
>==618698==  possible), you can try to increase the size of the
>==618698==  main thread stack using the --main-stacksize= flag.
>==618698==  The main thread stack size used in this run was 8388608.
>==618698== Stack overflow in thread #1: can't grow stack to 0x1ffe801000
>==618698== 
>==618698== Process terminating with default action of signal 11 (SIGSEGV)
>==618698==  Access not within mapped region at address 0x1FFE801FD8
>==618698== Stack overflow in thread #1: can't grow stack to 0x1ffe801000
>==618698==    at 0x482E110: _vgnU_freeres (vg_preloaded.c:59)
>==618698==  If you believe this happened as a result of a stack
>==618698==  overflow in your program's main thread (unlikely but
>==618698==  possible), you can try to increase the size of the
>==618698==  main thread stack using the --main-stacksize= flag.
>==618698==  The main thread stack size used in this run was 8388608.
>
>Hope this helps
>Pere
>
>
>
>_______________________________________________
>Tuxpaint-users mailing list
>Tux...@li...
>https://lists.sourceforge.net/lists/listinfo/tuxpaint-users