Re: [Tuxpaint-devel] Is this warning harmless?

[TOYAMA Shin-i. <sh...@wm...>]

Hi,

I think the reason for this warning is that the size of wchar_t is
4 bytes on linux but 2 bytes on windows.

I don't know what render_text_w() is doing, so I'm not sure if
this is the problem or not.

For example, the text circled in red in onscreen_keyboard (see 
attached) does not seem to be rendered on windows.

Does this seem relevant ?


TOYAMA Shin-ichi wrote in <617e94b2.5007%sh...@wm...>
>Hi,
>
>Recently, I've been dealing with a lot of bugs in the Windows
>version, and I've noticed that many clue of the bugs had been 
>appeared in the compile-time warnings.
>
>So,I checked the warnings again, and the following warning,
>which does not appear when compiling on Linux, caught my 
>attention.
>
>------------------------------------------------------------
>src/tuxpaint.c: In function 'render_text_w':
>src/tuxpaint.c:1685:27: warning: comparison is always true due to limited range 
>of data type [-Wtype-limits]
> 1685 |           else if (str[i] <= 0x0000FFFF)
>------------------------------------------------------------
>
>If this warning is correct, it means that the next conditional
>branch (0x00100000 - 001FFFFF) will never be reached.
>
>How can I confirm if it were a problem or not?
>
>Thanks!

-- 
TOYAMA Shin-ichi mailto:sh...@wm...