tsheetx-developers

[Tsheetx-developers] svn check in notice

[Scott M. <sco...@gm...>]

I've made another check in (3 actually): simple sheet, menu and banner items
now using JText, small fix to monthly sheet.

Also, I've created a new, better in my opinion, way to create the menus, but
we need to add some additional ACL entries before I can uncomment that block
of code.  Except for throwing lots of errors about not finding the missing
ACL's, it works pretty well.

-Scott

Re: [Tsheetx-developers] svn check in notice

[Scott M. <sco...@gm...>]

Another set of files checked in just now; working on fixing up the client
maintenance area, getting internationalization in those files.

In order to help me ensure that I'm fixing all the text on the pages via the
JText calls, currently all JText calls prepend a 'j' in front of every
string.  Consider that as a type of debugging output :-)

-Scott

Re: [Tsheetx-developers] Next set of tasks

[Peter L. <pal...@gm...>]

Greetings Fellow Developers,
I'm now back from my trip and have updated my tsheet code copy to the 
latest you've created. So I am wondering where I should resume my 
contribution to the development? My two ideas for development are: a) to 
try and clean up the css in the forms so that all formatting is done via 
css and none by any local bits of html formatting; b) review the state 
of the time submission and approval process, and develop it more fully.

Any suggestions welcomed.
Peter

Re: [Tsheetx-developers] Next set of tasks

[Scott M. <sco...@gm...>]

Either and both of those would be excellent places to continue; and if you
want you can help convert output to use the new JText calls in the files you
hit.

On Sat, Mar 19, 2011 at 4:43 AM, Peter Lazarus <pal...@gm...> wrote:

> Greetings Fellow Developers,
> I'm now back from my trip and have updated my tsheet code copy to the
> latest you've created. So I am wondering where I should resume my
> contribution to the development? My two ideas for development are: a) to try
> and clean up the css in the forms so that all formatting is done via css and
> none by any local bits of html formatting; b) review the state of the time
> submission and approval process, and develop it more fully.
>
> Any suggestions welcomed.
> Peter
>

Re: [Tsheetx-developers] Next set of tasks

[Mark W. <ma...@rw...>]

Hi Peter,

Hope you have had a good holiday, if you could just continue where you 
left off with the css stuff and submission stuff that would be great :)

Mark

_____________________________________________

Mob:  07725 695178
Email: ma...@rw...


On 19/03/2011 09:43, Peter Lazarus wrote:
> Greetings Fellow Developers,
> I'm now back from my trip and have updated my tsheet code copy to the 
> latest you've created. So I am wondering where I should resume my 
> contribution to the development? My two ideas for development are: a) 
> to try and clean up the css in the forms so that all formatting is 
> done via css and none by any local bits of html formatting; b) review 
> the state of the time submission and approval process, and develop it 
> more fully.
>
> Any suggestions welcomed.
> Peter
>

[Tsheetx-developers] svn check in notice

[Scott M. <sco...@gm...>]

I've made several fixes to the simple.php, simple_actions.php and simple.js
files.  The simple timesheet stuff had been broken during the OO
modifications, so, they are now using JText, and they are working again.

I'm still in the midst of changing how the simple sheet works; I'm
significantly restricting what gets deleted and re-added by putting in the
"old values" into the post variables, and then testing to see if anything
for a particular entry actually changed.  If they change, then a deletion of
only those things that changed, and then a new addition is performed with
the new information.  I am contemplating storing the transaction numbers and
"modifying" entries instead, but that hasn't happened yet :-)

There is a "bug" that may get tickled by this: if the php.ini file specifies
a very small limit to post entries, the data that should be getting to
simple_actions.php may be silently truncated.  This situation should be
tested for during the installation process, but isn't yet.

-Scott

Re: [Tsheetx-developers] svn check in notice

[Scott M. <sco...@gm...>]

Hi all,

Late yesterday I checked in more updates to the simple
form/actions/javascript, and included the code to check if the PHP
configuration variable max_post_size was set to at least 32K.  If not, a
"Fatal Problem" page is displayed explaining that the php.ini file needs to
be modified and that entry needs to be set to at least 32K.  This should
happen, I believe, even when the system needs to be initially installed.

I'm hopeful this addition mitigates the "silently truncated" problem that
could otherwise occur.

-Scott

On Wed, Mar 23, 2011 at 9:24 PM, Scott Miller <sco...@gm...>wrote:

> I've made several fixes to the simple.php, simple_actions.php and simple.js
> files.  The simple timesheet stuff had been broken during the OO
> modifications, so, they are now using JText, and they are working again.
>
> I'm still in the midst of changing how the simple sheet works; I'm
> significantly restricting what gets deleted and re-added by putting in the
> "old values" into the post variables, and then testing to see if anything
> for a particular entry actually changed.  If they change, then a deletion of
> only those things that changed, and then a new addition is performed with
> the new information.  I am contemplating storing the transaction numbers and
> "modifying" entries instead, but that hasn't happened yet :-)
>
> There is a "bug" that may get tickled by this: if the php.ini file
> specifies a very small limit to post entries, the data that should be
> getting to simple_actions.php may be silently truncated.  This situation
> should be tested for during the installation process, but isn't yet.
>
> -Scott
>