Re: [Tsheetx-developers] Monthly updated to OO format

[David T. <tom...@us...>]

I would recommend not creating a branch for timezone handling changes, for exactly this reason, you're spliting your efforts and merging is much harder than simple synchronisation with commit and update cycles. Yes, things will get broken, but fixing them early is easier than later.
 
Mark, the class choices seem fine, go for it.
Cheers
 



Date: Sat, 24 Sep 2011 17:58:37 +0100
From: ma...@rw...
To: tsh...@li...
Subject: [Tsheetx-developers] Monthly updated to OO format


Hi All, 

I have made some extensive changes to Monthly.php to object orientate the data selection from the db.  This should reduce the level of repeated code across the various pages significantly once fully propagated. It also forms a good starting point to build the timezone stuff into.

The two new classes are: 



TsxTime -a single time entity (i.e. one row from the db)
TsxTimeList - a set of times that have been retrieved from the db. (basically an array of TsxTime objects) with supporting functionsThese updates have been made to the 2.0-branch.  The timezone work still needs consideration but this code should help make things slightly easier.

Please let me know your opinions.

Thanks

Mark