Re: [Tsheetx-developers] Database Config Tables

[Scott M. <sco...@gm...>]

Ok, my work on 2.0 demo has just been checked in; the only places left that
deal with the original database_credentials file are the new config.php
file, and the old and new installation areas (they haven't been "fixed"
yet).

-Scott

On Tue, Feb 22, 2011 at 6:49 PM, Scott Miller <sco...@gm...>wrote:

> Well, I'd been just commenting the unneeded
> include(database_credentials.inc) and include(table_names.inc) pieces out,
> but yeah, deleting them once I've proven to myself they weren't needed any
> more is probably the right thing to do.
>
> I haven't touched much (anything?) that included the html stuff, so, I
> haven't had a chance to remove any of that.
>
> Aside from what we've been removing from the global variables area
> (configs, table names), I'm not sure which other items are left.  The
> siteclosed stuff was a hasty add by me when I needed to upgrade our
> production system, so, improve away :-)
>
> -Scott
>
>
>
> On Tue, Feb 22, 2011 at 5:10 PM, Mark Wrightson <ma...@rw...>wrote:
>
>>  Hi Scott,
>>
>> There shouldn't be any references left to database_credentials other than
>> in config.php.  I dont think we should remove the database_credentials file
>> until the new installer / upgrader is finished.  The file mysql.db.inc is
>> now redundant (almost).  There is a new database class in the include
>> directory that handles all of the db stuff.
>>
>> Oops - I thought i had got rid of all of the non OO references to tables!
>>
>> There is one section that still needs looking at and that is global
>> variables.  Global variables just don't work in the new system (which is
>> good news! as they are horrible)  However there are still some references to
>> them that haven't been corrected.
>>
>> With reference to the siteClosed stuff.  I am intending to update all of
>> the login / logout / forgotpass stuff and that will include updating
>> siteclosed.  Im mentioning it here as there is some global references to
>> siteclosed.
>>
>> The HTML stuff from config is not used anywhere anymore (at least it
>> shouldn't be)  Feel free to start removing it!
>> What is the reason for not being able to move the ACL pieces just yet?
>>
>> It sounds like you've got quite a lot done.  Good Work!
>> I wish i had more time available to help out.
>>
>>
>> Mark
>>
>> _____________________________________________
>>
>> Mob:  07725 695178
>> Email: ma...@rw...
>>
>>
>> On 22/02/2011 15:04, Scott Miller wrote:
>>
>> Hey Mark,
>>
>> I'm getting ready to check my work in, I believe your new config.php file
>> is the way to go, so, I'm going to make an attempt to remove all reference
>> to the database_credentials.inc file in the code, except for the install
>> part, that will happen later.  I've removed the non-OO table references in
>> the class.AuthenticationManager.php, and changed that file to grab the LDAP
>> configuration from the new configuration table, and I'm loading those
>> variables in my OO associative array.
>>
>> I would like to eliminate any usage of the old config table except for the
>> the HTML and ACL (security) pieces for now.  The long term plan should be to
>> remove the old table entirely, but we need to take smallish steps to get
>> there :-)
>>
>> Feed back on my install stuff email or any of this stuff would be
>> appreciated...
>>
>> -Scott
>>
>> On Mon, Feb 21, 2011 at 5:08 PM, Scott Miller <sco...@gm...>wrote:
>>
>>> Hey Mark,
>>>
>>> To quickly be able to test my upgrade script, I had to take the old
>>> install directory structure and placed it into a directory called oldinstall
>>> off the root context directory.  For what I've done thus far, it worked
>>> great.  So, I think we've got the ability to allow the old upgrade/install
>>> stuff to continue to function, we just have to direct people to have their
>>> browser open the oldinstall/index.php page, or we could put a link in your
>>> new install functionality too.  But, we can continue working on a new
>>> install methodology at the same time too.  Eventually the oldinstall
>>> directory will just disappear when the new stuff is done.
>>>
>>> -Scott
>>>
>>>
>>>