Menu

#24 Fix shift sounds

Unstable_(example)
accepted
None
1
2020-10-01
2019-08-19
No

Hi,

This patch fix a small issue in the shift sounds. The function getShiftDirection returns targetgear_rel, but this variable doesn't always contain the last shift direction leading to incorrect sounds at upshift/downshift.

1 Attachments

Discussion

  • Emanuele Sorce

    Emanuele Sorce - 2019-08-21

    Thanks Kirada. I will review then merge your patch soon :D

     
  • Emanuele Sorce

    Emanuele Sorce - 2019-09-04

    Thanks for the patience. I merged your fix in [r964]. Thanks for the contribution!

     

    Related

    Commit: [r964]

  • Onsemeliot

    Onsemeliot - 2020-10-01
    • status: open --> accepted
    • assigned_to: Emanuele Sorce
     

Log in to post a comment.