Re: [Torcs-devel] Patch for olethros on Fedora

[Bernhard W. <be...@bl...>]

Hi Jeremy

Using std:: here is not a good idea (because of some other compiler and 
linking issues), could you provide a fix which uses the c isnan?

What is a bit weird that we use the isnan in various places, what makes 
this special location for fedora (the others seem to work for you)?

Kind regards

Bernhard

On 09.05.2017 18:40, Jeremy Bennett wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Found compiling for Fedora 25:
> 
>> $ uname -a Linux buzz 4.9.14-200.fc25.x86_64 #1 SMP Mon Mar 13
>> 19:26:40 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
> 
> inan needs to be qualified as std:inan. Diff:
> 
> $ cvs diff src/drivers/olethros/geometry.cpp
> Index: src/drivers/olethros/geometry.cpp
> ===================================================================
> RCS file: /cvsroot/torcs/torcs/torcs/src/drivers/olethros/geometry.cpp,v
> retrieving revision 1.9
> diff -r1.9 geometry.cpp
> 373c373
> <                       if (isnan(r)) {
> - ---
>> if (std::isnan(r)) {
> 
> ChangeLog entry:
> 
> 	* src/drivers/olethros/geometry.cpp (EstimateSphere):
> 	Qualify inan as std::inan.
> 
> Also filed as support request 12.
> 
> HTH,
> 
> 
> Jeremy
> 
> - -- 
> Tel:     +44 (1590) 610184
> Cell:    +44 (7970) 676050
> SkypeID: jeremybennett
> Twitter: @jeremypbennett
> Email:   jer...@em...
> Web:     www.embecosm.com
> PGP key: 1024D/BEF58172FB4754E1 2009-03-20
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
> 
> iEYEARECAAYFAlkR8PYACgkQvvWBcvtHVOGFeACfV7voQ5hHUnSF3hVNj4hGU/CS
> S4QAnRCfemdeFTw3Gj6tD895sCNGER0d
> =8ovI
> -----END PGP SIGNATURE-----
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Torcs-devel mailing list
> Tor...@li...
> https://lists.sourceforge.net/lists/listinfo/torcs-devel
>