tkdiff / Bugs / #105 search string gets eval'd, causes error if there's a space or $ in it

Side-by-side diff viewer, editor and merge preparer

#105 search string gets eval'd, causes error if there's a space or $ in it

Milestone: V6.0

Status: closed-fixed

Owner: michael-m

Labels: None

Priority: 5

Updated: 6 days ago

Created: 6 days ago

Creator: DorothyR

Private: No

The search string seems to be erroneously evaluated in V6.0 but not V5.7. In one of the error logs below, I searched for "option add" and in the other I searched for "$g". In the case of a space, putting quotes around the search string will succeed, but for the dollar sign, curly braces are necessary.

Filing bug while I still have the log files.

2 Attachments

search_bug_eval.log

search_bug_space.log

Discussion

michael-m - 6 days ago

assigned_to: michael-m
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

michael-m - 6 days ago

Ya know, I'd swear this was fixed once before. And its odd if it does really work for V5.7; maybe I'll look to see if anything appears changed between the two releases. In any event, standby...

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

michael-m - 6 days ago

status: open --> accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

michael-m - 6 days ago

OK - understand what happened - extra reparsing from EVAL caused unprotected search term to look like TCL and it all went south. V5.7 did not use "eval", which was added trying to simplify the command. Will repair.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

michael-m - 6 days ago

status: accepted --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

michael-m - 6 days ago

Fix scheduled for eventual new version; can refer to commit 225 if details desired in the interim

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

search string gets eval'd, causes error if there's a space or $ in it

Side-by-side diff viewer, editor and merge preparer

Group

Searches

Help

#105 search string gets eval'd, causes error if there's a space or $ in it

Discussion