#161 annotate function in git and cvs

[Anders Gustavsson]

When i try the show annotations function with git as backend i get the following message:

can't read "::annotate::0::file": no such variable
can't read "::annotate::0::file": no such variable
while executing
"set ::annotate::$my_idx\::file"
(".annotate*" arm line 4)
invoked from within
"switch -glob $topwin {
".workdir" {
if {$ok_gitk} {
$topwin.menubar.gittools entryconfigure "gitk" -state normal -command { cvs_e..."
(procedure "git_tools_menu" line 19)
invoked from within
"git_tools_menu $topwin"
(procedure "menubar_menus" line 30)
invoked from within
"menubar_menus $blamewin"
(in namespace eval "::annotate::0" script line 290)
invoked from within
"namespace eval $my_idx {
set my_idx [uplevel {concat $my_idx}]
variable revision [uplevel {concat $revision}]
variable fnam [uplevel..."
(procedure "annotate::new" line 10)
invoked from within
"annotate::new $revflag "$filepath" "git_r""
(procedure "git_annotate_r" line 11)
invoked from within
"git_annotate_r $rev "$filename""
(in namespace inscope "::branch_diagram::0" script line 3)
invoked from within
"::namespace inscope ::branch_diagram::0 {
set rev [EitherOrHead]
git_annotate_r $rev "$filename"
}"
invoked from within
".branch_diagram0.annotate invoke"
("uplevel" body line 1)
invoked from within
"uplevel #0 [list $w invoke]"
(procedure "tk::ButtonUp" line 22)
invoked from within
"tk::ButtonUp .branch_diagram0.annotate"
(command bound to event)

and with cvs as backend:

can't read "::annotate::0::file": no such variable

can't read "::annotate::0::file": no such variable
while executing
"set ::annotate::$my_idx\::file"
(".annotate*" arm line 4)
invoked from within
"switch -glob $topwin {
".workdir" {
if {$ok_gitk} {
$topwin.menubar.gittools entryconfigure "gitk" -state normal -command { cvs_e..."
(procedure "git_tools_menu" line 19)
invoked from within
"git_tools_menu $topwin"
(procedure "menubar_menus" line 30)
invoked from within
"menubar_menus $blamewin"
(in namespace eval "::annotate::0" script line 290)
invoked from within
"namespace eval $my_idx {
set my_idx [uplevel {concat $my_idx}]
variable revision [uplevel {concat $revision}]
variable fnam [uplevel..."
(procedure "annotate::new" line 10)
invoked from within
"annotate::new $revflag "$filename" "cvs_r""
(procedure "cvs_annotate_r" line 13)
invoked from within
"cvs_annotate_r $rev "$module_dir/$filename""
(in namespace inscope "::branch_diagram::0" script line 3)
invoked from within
"::namespace inscope ::branch_diagram::0 {
set rev [EitherOrHead]
cvs_annotate_r $rev "$module_dir/$filename"
..."
invoked from within
".branch_diagram0.annotate invoke"
("uplevel" body line 1)
invoked from within
"uplevel #0 [list $w invoke]"
(procedure "tk::ButtonUp" line 22)
invoked from within
"tk::ButtonUp .branch_diagram0.annotate"
(command bound to event)

[DorothyR]

Well that was interesting. It happens if the external tool gitk is installed, and the bug seems to have been there a long time. I guess I haven't had gitk on my machine for awhile. Fixed in version 9.6.2, which will be released shortly.

[Anders Gustavsson]

Thanks for fixing! Works just fine in 9.6.2!