#90 "Copy of copy" of timeslots copies the former timeslot

[Francesco]

Steps to reproduce:
1) Copy an existing timeslot (I'm in a subtask) (let's call it timeslot A)
2) Paste the copied timeslot and maybe edit it changing hours and days (let's call the new timeslot B)
3) Copy the timeslot B
4) Paste it: the timeslot A dates appears in the new timeslot C
I suppose that I shoud have the dates of timeslot B
Moreover (but I really don't know if it's a bug or a wanted feature) in the .xml file all the copied timeslots have the same "timeslotId"

[Andrey Glazachev]

Good day, Francesco.
It is a bug. Should be the dates fo timeslot B, and yes, timeSlotId should be null (or new).
If you can try to fix it, I'll review the branch.

Thanks for the feedback )

[Francesco]

I verified that the problems is in the wrong timeslotId of the new timeslot copied. I'll try to fix it. I'll let you know

[Francesco]

Hi Andrey,
I'm stubborn :D and I found a solution.
Here is attached the patch file that you can apply. Anyway check the fixing
and apply a better solution if you have one.

Regards

Francesco

Il giorno ven 31 mag 2019 alle ore 09:12 Francesco frotondella@users.sourceforge.net ha scritto:

I verified that the problems is in the wrong timeslotId of the new
timeslot copied. I'll try to fix it. I'll let you know

---

• [bugs:#90] https://sourceforge.net/p/timeslottracker/bugs/90/ "Copy of
  copy" of timeslots copies the former timeslot*

Status: open
Group: 1.2.1
Created: Tue May 28, 2019 12:41 PM UTC by Francesco
Last Updated: Wed May 29, 2019 01:19 AM UTC
Owner: nobody

Steps to reproduce:
1) Copy an existing timeslot (I'm in a subtask) (let's call it timeslot A)
2) Paste the copied timeslot and maybe edit it changing hours and days
(let's call the new timeslot B)
3) Copy the timeslot B
4) Paste it: the timeslot A dates appears in the new timeslot C
I suppose that I shoud have the dates of timeslot B
Moreover (but I really don't know if it's a bug or a wanted feature) in
the .xml file all the copied timeslots have the same "timeslotId"

---

Sent from sourceforge.net because you indicated interest in
https://sourceforge.net/p/timeslottracker/bugs/90/

To unsubscribe from further messages, please visit
https://sourceforge.net/auth/subscriptions/

[Andrey Glazachev]

Hi, Francesco.

The old DnD code is not good. So i was looking for a simple solution based on your patch.
And I think, we should create the new timeslot instead of cloning.

Check out the bug-90-timeslots branch. It fixes the bug for me. Test it with your data.
Email me, if you have any ideas/questions.

Regards, Andrey