Re: [TiLP-devel] Gentoo stuff

[Romain <ro...@li...>]

Hi,

>>> against Gtk 2.4, which the Gentoo ebuild fixes with this line (which
>>> happens right before the ebuild runs the configure command):
>>> sed -e 's/GTK_DISABLE_DEPRECATED/GTK_DEPRECATED/g' -i src/Makefile.in
>>
>> This is the wrong fix for this issue. I guess this does precisely the
>> contrary, ie it probably enables deprecated widgets, which is not what
>> we want. Better drop the -D entirely, or patch TiLP to not use the
>> deprecated widget, but TiLP may not build with GTK 2.2 after that.

at the time being, the -D_DEPRECATED needs to be used with GTK+ 2.4.
The best way is to fix that. I will do it asap.

>> I fixed this bug (in labels.c) ages ago already. It took me two hours
>> to track it down. Moreover, the Gentoo patch is simply completely
>> wrong and doesn't do the right thing. Trash it, the author of this

I agree. If path is shorter, the label is not refreshed any more.
Anyways, I rewritten this part, the code was too buggy and unclear.

> Hopefully, I'll be able to get 6.71 ebuild working. If your patch has
> been applied to the main TiLP branch, then we can safely drop the
> Gentoo "fix". (I'm sorry, I haven't been closely following TiLP bug
> fixes for quite some time, so I can only assume a real fix was checked
> in since this patch no longer applies cleanly to the 6.71 source) I
> will also disable the sed kludge and see what happens - i.e. how badly
> Gtk-2.4 breaks things :-)

ok

>> What's this ".keep" directory that is special-cased in the patch ?
>> This patch seems bogus to me.
>
> AFAIK, this is to work around a Gentoo Portage sandbox violation when
> building TiLP. Portage sandboxes the builds for all software, so that
> it is only allowed to compile and install to a particular directory. (I
> am mostly unfamiliar with FreeBSD ports, so I don't know if ports
> enforces a sandbox, or just relies on portfiles being "correct".)
> Apparently, the TiLP build process does something with a 'registry' and
> in doing so, modifies files outside the build root. I'm not sure what
> "registry" the Gentoo people meant - has something like this been added
> to TiLP recently?

The registry file is read only. The plugin dir (/usr/lib/tilp) is ro, too=
.
There is just one file TiLP is modifying: the ~/.tilp config file.

TiLP should not modify anything else.

thx, roms.
--=20
Romain Li=E9vin :		<ro...@li...>
Web site :		http://www.lievin.net
"Linux, y'a moins bien mais c'est plus cher !"