Re: [TiLP-devel] Gentoo stuff

[Julien B. <jb...@jb...>]

Brent Redeker <bre...@cc...> wrote:

Hi,

>> I fixed this bug (in labels.c) ages ago already. It took me two hours
>> to track it down. Moreover, the Gentoo patch is simply completely
>> wrong and doesn't do the right thing. Trash it, the author of this
>> patch didn't bother enough to dig into the code and understand where
>> the bug came from, and why it was a bug in the first place.
>
> Hopefully, I'll be able to get 6.71 ebuild working. If your patch has
> been applied to the main TiLP branch, then we can safely drop the

I committed it into the trunk (this was in revision 357 and 358).

> Gentoo "fix". (I'm sorry, I haven't been closely following TiLP bug
> fixes for quite some time, so I can only assume a real fix was checked
> in since this patch no longer applies cleanly to the 6.71 source) I

Romain modified the function again, I just hope he didn't manage to
break it again...

> will also disable the sed kludge and see what happens - i.e. how badly
> Gtk-2.4 breaks things :-)

That would be interesting.

>> What's this ".keep" directory that is special-cased in the patch ?
>> This patch seems bogus to me.
>
> AFAIK, this is to work around a Gentoo Portage sandbox violation when
> building TiLP. Portage sandboxes the builds for all software, so that

I seriously doubt it is a build-time problem, as the patch applies to
the code that loads the plugins...

> it is only allowed to compile and install to a particular
> directory. (I am mostly unfamiliar with FreeBSD ports, so I don't know
> if ports enforces a sandbox, or just relies on portfiles being
> "correct".)  Apparently, the TiLP build process does something with a

Don't tell me they're spreading ".keep" directory accross the
filesystem to keep some portage-related information in it ?

Anyway, if this is the case, the correct fix for this is to have the
plugin loading code ignore hidden files and directory, and it is
certainly not to add a special case for gentoo stuff. Once again,
someone didn't bother enough to do things the Right Way (tm).

> 'registry' and in doing so, modifies files outside the build root. I'm
> not sure what "registry" the Gentoo people meant - has something like
> this been added to TiLP recently?

It's the registry for the tiffep server, which is still an
experimental thing, and shouldn't be installed.

> I'm sorry, I don't know much more. I haven't had time to really try
> and look at what these patches are doing. Thanks for your help, though.

You're welcome.

JB.

-- 
Julien BLACHE                                   <http://www.jblache.org> 
<jb...@jb...>                                  GPG KeyID 0xF5D65169