Re: [TiLP-devel] Gentoo stuff

[Brent R. <bre...@cc...>]

Hi Julien, thanks for looking at this stuff.

On Apr 25, 2004, at 2:35 PM, Julien BLACHE wrote:

> It wasn't related to a locale issue, but some locales helped trigger
> the bug, which was a basic coding mistake because someone forgot THAT
> YOU MUST NEVER MODIFY A STRING RETURNED BY A GTK FUNCTION UNLESS THE
> DOCUMENTATION EXPLICITLY TELLS THAT YOU CAN. And I bet there a couple
> of other similar issues at some other places in TiLP, but I do not
> have the time for a complete audit...
>
>> against Gtk 2.4, which the Gentoo ebuild fixes with this line (which
>> happens right before the ebuild runs the configure command):
>> sed -e 's/GTK_DISABLE_DEPRECATED/GTK_DEPRECATED/g' -i src/Makefile.in
>
> This is the wrong fix for this issue. I guess this does precisely the
> contrary, ie it probably enables deprecated widgets, which is not what
> we want. Better drop the -D entirely, or patch TiLP to not use the
> deprecated widget, but TiLP may not build with GTK 2.2 after that.
>
> Without a build log, I can't say much more.
>
>> *tilp-6.68-r2 (13 Apr 2004)
>>
>>    13 Apr 2004; Patrick Kursawe <pho...@ge...>
>>    tilp-6.68-r1.ebuild,
>>    tilp-6.68-r2.ebuild, files/formatbug.patch:
>>    Traced bug #40263 to a buffer overflow, provided patch.
>
> I fixed this bug (in labels.c) ages ago already. It took me two hours
> to track it down. Moreover, the Gentoo patch is simply completely
> wrong and doesn't do the right thing. Trash it, the author of this
> patch didn't bother enough to dig into the code and understand where
> the bug came from, and why it was a bug in the first place.

Hopefully, I'll be able to get 6.71 ebuild working. If your patch has 
been applied to the main TiLP branch, then we can safely drop the 
Gentoo "fix". (I'm sorry, I haven't been closely following TiLP bug 
fixes for quite some time, so I can only assume a real fix was checked 
in since this patch no longer applies cleanly to the 6.71 source) I 
will also disable the sed kludge and see what happens - i.e. how badly 
Gtk-2.4 breaks things :-)
>
>> *tilp-6.68-r1 (29 Mar 2004)
>>
>>    29 Mar 2004; Patrick Kursawe <pho...@ge...>
>>    tilp-6.68-r1.ebuild,
>>    files/6.68-keepdir.patch:
>>    Some changes because of bug #40263
>
> What's this ".keep" directory that is special-cased in the patch ?
> This patch seems bogus to me.

AFAIK, this is to work around a Gentoo Portage sandbox violation when 
building TiLP. Portage sandboxes the builds for all software, so that 
it is only allowed to compile and install to a particular directory. (I 
am mostly unfamiliar with FreeBSD ports, so I don't know if ports 
enforces a sandbox, or just relies on portfiles being "correct".)  
Apparently, the TiLP build process does something with a 'registry' and 
in doing so, modifies files outside the build root. I'm not sure what 
"registry" the Gentoo people meant - has something like this been added 
to TiLP recently?

I'm sorry, I don't know much more. I haven't had time to really try and 
look at what these patches are doing. Thanks for your help, though.

Brent